Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: build: finish replacing paver #34700

Merged
merged 1 commit into from
May 6, 2024

Conversation

kdmccormick
Copy link
Member

@kdmccormick kdmccormick commented May 6, 2024

Reverts #34554, which causes compilation of edX.org's
legacy comprehensive theme to be skipped in their deployment pipeline.
We have not determined the precise cause yet, but it seems like the
compile_sass management command is not correctly getting the
list of comprehensive theme directories from Django settings.

@jesperhodge jesperhodge merged commit 4c0284b into master May 6, 2024
109 checks passed
@jesperhodge jesperhodge deleted the revert-34554-kdmccormick/assets-final branch May 6, 2024 16:57
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@kdmccormick
Copy link
Member Author

Found the bug. Fix here: #34701

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

kdmccormick added a commit that referenced this pull request May 15, 2024
EDX_PLAFORM_THEME_DIRS was the original name,
but it was changed to COMPREHENSIVE_THEME_DIRS
in #34700.
kdmccormick added a commit that referenced this pull request May 16, 2024
EDX_PLAFORM_THEME_DIRS was the original name,
but it was changed to COMPREHENSIVE_THEME_DIRS
in #34700.
kdmccormick added a commit to kdmccormick/edx-platform that referenced this pull request May 17, 2024
EDX_PLAFORM_THEME_DIRS was the original name,
but it was changed to COMPREHENSIVE_THEME_DIRS
in openedx#34700.
kdmccormick added a commit that referenced this pull request May 17, 2024
EDX_PLAFORM_THEME_DIRS was the original name,
but it was changed to COMPREHENSIVE_THEME_DIRS
in #34700.

Redwood backport of: #34805
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants