Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: an issue where changing the transcript language code #34479

Merged
merged 1 commit into from
Dec 3, 2024
Merged

fix: an issue where changing the transcript language code #34479

merged 1 commit into from
Dec 3, 2024

Conversation

DmytroAlipov
Copy link
Contributor

Description

Fixed an issue where changing the transcript language code would cause both the old and new transcript to be displayed. But in this case, you won’t be able to download the transcript from the old code, since the link is invalid.

The current MR is a consequence of this MR.

To reproduce, do the following:

  1. The Course Authoring MFE must be configured, and the new_core_editors.use_new_video_editor flag must be enabled in the admin panel.
  2. Add a video to the Unit.
  3. Go to the editor. Add a valid transcript.
  4. Now you can change the language in an existing transcript.
  5. Now, when changing the language, the old one will remain in place and a new one will be added. You will see this when you reload the page.

tr_0

tr_1

tr_2

  1. Also, make sure you download the transcripts to your computer. It will only work for the last selected language. For other x there will be an error.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 8, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Apr 8, 2024 •
edited
Loading

Thanks for the pull request, @DmytroAlipov!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/wg-maintenance-edx-platform. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@DmytroAlipov DmytroAlipov added the bug Report of or fix for something that isn't working as intended label Apr 8, 2024
@DmytroAlipov DmytroAlipov force-pushed the fix-transcript-replacement branch 4 times, most recently from c0c50d8 to d984947 Compare April 8, 2024 14:06
@mphilbrick211 mphilbrick211 added the needs reviewer assigned PR needs to be (re-)assigned a new reviewer label May 16, 2024
dyudyunov
dyudyunov reviewed Jul 24, 2024
View reviewed changes
xmodule/video_block/video_handlers.py
Comment on lines +539 to +541
if language_code != new_language_code:
self.transcripts.pop(language_code, None)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have the same check in the add_or_update_transcripts function, why do you duplicate it here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dyudyunov Right, thanks for noticing this redundant code. Initially, I wanted to do it through a separate function. But then I realized that it was redundant. And after moving the logic to studio_transcript I forgot to delete add_or_update_transcripts.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the add_or_update_transcripts function.

@DmytroAlipov DmytroAlipov force-pushed the fix-transcript-replacement branch 6 times, most recently from da1260a to 12279a3 Compare July 31, 2024 16:02
idegtiarov
idegtiarov reviewed Aug 1, 2024
View reviewed changes
Copy link
Contributor

@idegtiarov idegtiarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DmytroAlipov DmytroAlipov force-pushed the fix-transcript-replacement branch 2 times, most recently from 1d5ce29 to 60c6641 Compare August 2, 2024 10:01
@DmytroAlipov DmytroAlipov force-pushed the fix-transcript-replacement branch 3 times, most recently from 7033fe9 to 4b7a893 Compare October 30, 2024 08:57
@itsjeyd itsjeyd removed the needs reviewer assigned PR needs to be (re-)assigned a new reviewer label Nov 28, 2024
@itsjeyd
Copy link
Contributor

itsjeyd commented Nov 28, 2024

@DmytroAlipov Would you mind rebasing your changes again to trigger another test run? We'll need a green build to merge.

@itsjeyd itsjeyd added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Nov 28, 2024
@DmytroAlipov
fix: fix transcript replacement
911bf73 
Fixed an issue where changing the transcript language code would
cause both the old and new transcript to be displayed.
But in this case, you won’t be able to download the transcript
from the old code, since the link is invalid.
@DmytroAlipov DmytroAlipov force-pushed the fix-transcript-replacement branch from 4b7a893 to 911bf73 Compare November 28, 2024 13:19
@DmytroAlipov
Copy link
Contributor Author

@itsjeyd done

@itsjeyd
Copy link
Contributor

itsjeyd commented Nov 28, 2024

Great, thanks @DmytroAlipov!

@feanil Could you please merge this PR? It was reviewed by @idegtiarov (CC) but AFAICT they don't have write access to this particular repo (per info from Core Contributors to the Open edX Project).

@itsjeyd itsjeyd removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Nov 28, 2024
@feanil feanil merged commit 0baf71c into openedx:master Dec 3, 2024
51 checks passed
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@DmytroAlipov DmytroAlipov deleted the fix-transcript-replacement branch December 3, 2024 18:19
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been rolled back from the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been rolled back from the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dyudyunov dyudyunov dyudyunov left review comments

@idegtiarov idegtiarov idegtiarov left review comments

@feanil feanil feanil approved these changes

Assignees
No one assigned
Labels
bug Report of or fix for something that isn't working as intended open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@DmytroAlipov @openedx-webhooks @itsjeyd @edx-pipeline-bot @feanil @idegtiarov @dyudyunov @mphilbrick211