chore: add .nvmrc to match node version in Dockerfile #34307
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feanil
approved these changes
Feb 28, 2024
There was a problem hiding this comment.
Annoying that you can't leave a comment in the .nvmrc but maybe you could add the fact that it's 16.14 on purpose to the commit message as well? Not a blocker for merging since it's in the PR description but I like when kind of info is in the commit if it's not in a comment.
The use of 16.14 instead of 16 is intentional, as newer versions of node 16 lead to dependency issues.
brian-smith-tcril
force-pushed
the
nvmrc
branch
from
9aae26b to
a065013
Compare
Yeah, it seems it's quite strict (from the README)
|
feanil
approved these changes
Feb 28, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It is now standard practice to use
.nvmrcfiles throughout the frontend repos to specify the appropriate node version. I intentionally used16.14instead of16because I encountered issues when runningnpm cion node16.20.16.14is the version specified in theDockerfileedx-platform/Dockerfile
Lines 116 to 118 in 1339313