feat: fix pull_translations for production deployment #34306
Conversation
Makefile paver usage replaced with manage.py. This avoids running the production-unsuitable `pavelib.prereqs.install_prereqs` step during deployments.
|
Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
openedx-webhooks
added
the
open-source-contribution
|
@timmc-edx @dianakhuang this works fine on my Please let me know if it looks good to you. We're likely to need Ansible to set the environment variables for production |
This reverts commit 70eb142 and makes the following changes: - No need to install atlas directly -- the openedx-atlas package actually has what we need already. - After openedx/edx-platform#34306 we shouldn't encounter npm issues.
|
Oh nice! I'll give this a shot. |
This reverts commit 70eb142 and makes the following changes: - No need to install atlas directly -- the openedx-atlas package actually has what we need already. - After openedx/edx-platform#34306 we shouldn't encounter npm issues, so move task above NPM installs. - Try dropping the DSM and CFG vars and see if it still works.
This reverts commit 70eb142 and makes the following changes: - No need to install atlas directly -- the openedx-atlas package actually has what we need already. - After openedx/edx-platform#34306 we shouldn't encounter npm issues, so move task above NPM installs. - Try dropping the DSM and CFG vars and see if it still works.
|
@OmarIthawi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
This reverts commit 70eb142 and makes the following changes: - No need to install atlas directly -- the openedx-atlas package actually has what we need already. - After openedx/edx-platform#34306 we shouldn't encounter npm issues, so move task above NPM installs.
This is to support OEP-58: https://docs.openedx.org/projects/openedx-proposals/en/latest/architectural-decisions/oep-0058-arch-translations-management.html Changes since the #7119 attempt: - Move to just after main requirements are installed (just for faster feedback during testing, really) - Use already-installed `openedx-atlas` - Use variant-agnostic `EDX_PLATFORM_SETTINGS` rather than `DJANGO_SETTINGS_MODULE` - Use Ansible `environment` field for env vars - Drop `set -eu -o pipefail` since the script is now simple Most importantly, openedx/edx-platform#34306 has since merged, so we don't have to worry about the NPM conflicts we were getting previously.
This came up during discussion with @timmc-edx while trying to use
atlason 2U production:Makefile paver usage replaced with manage.py.
This avoids running the production-unsuitable
pavelib.prereqs.install_prereqsstep during deployments.TODO
Seems to be working okay on devstack
This pull request is part of the FC-0012 project which implements the Translation Infrastructure update OEP-58.