Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: open new editors from non-unit Studio container page #33575

Merged
merged 1 commit into from
May 31, 2024
Merged

fix: open new editors from non-unit Studio container page #33575

merged 1 commit into from
May 31, 2024

Conversation

ArturGaspar
Copy link
Contributor

Make the edit button on a container page for a non-unit block (i.e. an individual text, problem or video block) open the new editor when the relevant flag is enabled.

Description

The Studio Course Container page "Edit" button goes to legacy editors. This pull request fixes that so it goes to the new editors.

Impacts Course Author users.

Testing instructions

  1. Enable the new editors (create waffle flags new_core_editors.use_new_text_editor, new_core_editors.use_new_problem_editor, new_core_editors.use_new_video_editor enabled for everyone).

  2. Find the block id.

    1. Click "Edit" on a block.

    2. See that you are redirected to the new editor.

    3. Find the block id from the last path component of the URL.

      • e.g. block-v1:edX+DemoX+Demo_Course+type@html+block@030e35c4756a4ddc8d40b95fbbfff4d4.

  3. Go to http://localhost:18010/container/[block id].

    • e.g. http://localhost:18010/container/block-v1:edX+DemoX+Demo_Course+type@html+block@030e35c4756a4ddc8d40b95fbbfff4d4.

  4. Click the "Edit" button on the top right of the page.

  5. See that you are redirected to the new editor.

Repeat for the 3 block types: text, problem, video.

Deadline

None

Other information

Private-Ref: BB-7941

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 24, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Oct 24, 2023 •
edited
Loading

Thanks for the pull request, @ArturGaspar! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

tecoholic
tecoholic approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@tecoholic tecoholic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArturGaspar 👍

  • I tested this: Followed the test instructions and verified that the new editors are launched.
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation

Needed to run make cms-static when testing to get it to work. Shouldn't be a concern in deployments

@tecoholic
Copy link
Contributor

@jristau1984 @cablaa77 This should resolve TNL-10884.

@tecoholic
Copy link
Contributor

@navinkarkera One more PR to label "jira:2u" :)

@jristau1984 jristau1984 added the jira:2u We want an issue in the 2U Jira instance label Nov 9, 2023
@open-craft-grove
Copy link

Sandbox destroy request received.

@openedx-webhooks
Copy link

I don't have a Jira project configured for this repo in the private 2U Jira. Contact Ned Batchelder (@nedbat) to set up a project.

@open-craft-grove
Copy link

Sandbox destroy request received.

21 similar comments
@open-craft-grove
Copy link

Sandbox destroy request received.

@open-craft-grove
Copy link

Sandbox destroy request received.

@open-craft-grove
Copy link

Sandbox destroy request received.

@open-craft-grove
Copy link

Sandbox destroy request received.

@open-craft-grove
Copy link

Sandbox destroy request received.

@open-craft-grove
Copy link

Sandbox destroy request received.

@open-craft-grove
Copy link

Sandbox destroy request received.

@open-craft-grove
Copy link

Sandbox destroy request received.

@open-craft-grove
Copy link

Sandbox destroy request received.

@open-craft-grove
Copy link

Sandbox destroy request received.

@open-craft-grove
Copy link

Sandbox destroy request received.

@open-craft-grove
Copy link

Sandbox destroy request received.

@open-craft-grove
Copy link

Sandbox destroy request received.

@open-craft-grove
Copy link

Sandbox destroy request received.

@open-craft-grove
Copy link

Sandbox destroy request received.

@open-craft-grove
Copy link

Sandbox destroy request received.

@open-craft-grove
Copy link

Sandbox destroy request received.

@open-craft-grove
Copy link

Sandbox destroy request received.

@open-craft-grove
Copy link

Sandbox destroy request received.

@open-craft-grove
Copy link

Sandbox destroy request received.

@open-craft-grove
Copy link

Sandbox destroy request received.

@open-craft-grove
Copy link

Sandbox destroy request received.

10 similar comments
@open-craft-grove
Copy link

Sandbox destroy request received.

@open-craft-grove
Copy link

Sandbox destroy request received.

@open-craft-grove
Copy link

Sandbox destroy request received.

@open-craft-grove
Copy link

Sandbox destroy request received.

@open-craft-grove
Copy link

Sandbox destroy request received.

@open-craft-grove
Copy link

Sandbox destroy request received.

@open-craft-grove
Copy link

Sandbox destroy request received.

@open-craft-grove
Copy link

Sandbox destroy request received.

@open-craft-grove
Copy link

Sandbox destroy request received.

@open-craft-grove
Copy link

Sandbox destroy request received.

@open-craft-grove
Copy link

Sandbox deployment successful.

Sandbox LMS is available at pr-33575-139931.staging.do.opencraft.hosting
Sandbox Studio is available at studio.pr-33575-139931.staging.do.opencraft.hosting

Instance config : https://grove-stage-build-logs.nyc3.digitaloceanspaces.com/34602668-5657499809-config.yml
Instance requirements : https://grove-stage-build-logs.nyc3.digitaloceanspaces.com/34602668-5657499809-requirements.txt

@ArturGaspar
Copy link
Contributor Author

@jristau1984 @cablaa77 Hi, do you think you could find someone to review this, please?

@mphilbrick211 mphilbrick211 added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Feb 21, 2024
@jristau1984
Copy link
Contributor

This has been accepted by 2U partner support who have historically used this legacy view to help partners that are having react-based editor issues.

2U did not do a technical review of the change, as it looks like it has already been reviewed by the community.

@pkulkark
Copy link
Contributor

@mphilbrick211 @jristau1984 I can help review this PR as CC.

@mphilbrick211
Copy link

Perfect, thank you @pkulkark!

@tecoholic
Copy link
Contributor

@pkulkark Hi, would you be able to spare some CC hours to get this merged?

@pkulkark
Copy link
Contributor

pkulkark commented May 9, 2024

@ArturGaspar @tecoholic Sorry for the delay. I'll review this shortly.

@ArturGaspar @artur-kink
feat: open new editors from non-unit Studio container page
af7ba44 
Make the edit button on a container page for a non-unit block
(i.e. an individual text, problem or video block) open the new
editor when the relevant flag is enabled.
@ArturGaspar ArturGaspar force-pushed the artur/container-edit-new-editors branch from bd12b4b to af7ba44 Compare May 27, 2024 10:12
pkulkark
pkulkark approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@pkulkark pkulkark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

  • I tested this: I verified that the "edit" button in studio container page opens the new editors for text,video and problem components, as described in the testing instructions
  • I read through the code
  • [ ] I checked for accessibility issues N/A
  • [ ] Includes documentation N/A

@pkulkark pkulkark merged commit 90fc5f8 into openedx:master May 31, 2024
47 checks passed
@pkulkark pkulkark deleted the artur/container-edit-new-editors branch May 31, 2024 15:31
@openedx-webhooks
Copy link

@ArturGaspar 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@itsjeyd itsjeyd removed the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkulkark pkulkark pkulkark approved these changes

@tecoholic tecoholic tecoholic approved these changes

Assignees
No one assigned
Labels
jira:2u We want an issue in the 2U Jira instance open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@ArturGaspar @openedx-webhooks @tecoholic @open-craft-grove @jristau1984 @pkulkark @mphilbrick211 @edx-pipeline-bot @itsjeyd