Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: duplicate import dropdown for export page #33348

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

KristinAoki
Copy link
Member

Description

This PR removes the unused variable definition for studio_home_mfe_url and fixes the duplicate import options in the Tools dropdown when the waffle flag for the export mfe page is enabled.

Before
image

After
Screenshot 2023-09-26 at 3 40 43 PM

Supporting information

JIRA Ticket: TNL-11052

When I view from legacy page, the tools dropdown shows import twice but no export
However, from any new course auth page, the dropdown includes import and export

Testing instructions

  1. Enable contentstore.new_studio_mfe.use_new_export_page in django admin.
  2. Open a course in studio.
  3. Click on the tool dropdown.
  4. Should have Import, Export, Checklist

Deadline

None

@KristinAoki KristinAoki merged commit 645a762 into master Sep 27, 2023
@KristinAoki KristinAoki deleted the KristinAoki/update-studio-header branch September 27, 2023 16:09
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants