-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: updated edx-ui-toolkit to latest version #33161
Conversation
e46e9cb
to
eb17eec
Compare
16b02e1
to
b660662
Compare
388c1e6
to
b94bcd5
Compare
1bcdc8f
to
823e267
Compare
e96d64e
to
2114adf
Compare
ebb9af5
to
6544d88
Compare
…5/edx-ui-toolkit-upgrade
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BilalQamar95, do you mind adding some context as to why we're doing this? I'm not objecting, just curious.
Also, since @brian-smith-tcril is working on the Node 18 upgrade, this might have some bearing.
@@ -40,7 +40,7 @@ | |||
"datatables": "1.10.18", | |||
"datatables.net-fixedcolumns": "3.2.6", | |||
"edx-proctoring-proctortrack": "git+https://[email protected]/anupdhabarde/edx-proctoring-proctortrack.git#f0fa9edbd16aa5af5a41ac309d2609e529ea8732", | |||
"edx-ui-toolkit": "1.5.4", | |||
"edx-ui-toolkit": "github:openedx/edx-ui-toolkit", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we not publishing new versions of this automatically? Sounds like an issue in an of itself.
This is no longer necessary, I updated edx-ui-toolkit to a new version in #34873 that includes any changes that this was meant to capture. The new version previously couldn't be published to npm because it's ownership was not properly setup and it had no semantic release setup. I've fixed the permissions on the npmjs.org side and openedx/edx-ui-toolkit#413 will hopefully add auto-publishing so that we don't have to worry about this in the future. |
Description
Describe what this pull request changes, and why. Include implications for people using this change.
Design decisions and their rationales should be documented in the repo (docstring / ADR), per
OEP-19, and can be
linked here.
Useful information to include:
"Developer", and "Operator".
changes.
Supporting information
Link to other information about the change, such as Jira issues, GitHub issues, or Discourse discussions.
Be sure to check they are publicly readable, or if not, repeat the information here.
Testing instructions
Please provide detailed step-by-step instructions for testing this change.
Deadline
"None" if there's no rush, or provide a specific date or event (and reason) if there is one.
Other information
Include anything else that will help reviewers and consumers understand the change.