Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updated edx-ui-toolkit to latest version #33161

Closed
wants to merge 12 commits into from

Conversation

BilalQamar95
Copy link
Contributor

Description

Describe what this pull request changes, and why. Include implications for people using this change.
Design decisions and their rationales should be documented in the repo (docstring / ADR), per
OEP-19, and can be
linked here.

Useful information to include:

  • Which edX user roles will this change impact? Common user roles are "Learner", "Course Author",
    "Developer", and "Operator".
  • Include screenshots for changes to the UI (ideally, both "before" and "after" screenshots, if applicable).
  • Provide links to the description of corresponding configuration changes. Remember to correctly annotate these
    changes.

Supporting information

Link to other information about the change, such as Jira issues, GitHub issues, or Discourse discussions.
Be sure to check they are publicly readable, or if not, repeat the information here.

Testing instructions

Please provide detailed step-by-step instructions for testing this change.

Deadline

"None" if there's no rush, or provide a specific date or event (and reason) if there is one.

Other information

Include anything else that will help reviewers and consumers understand the change.

  • Does this change depend on other changes elsewhere?
  • Any special concerns or limitations? For example: deprecations, migrations, security, or accessibility.
  • If your database migration can't be rolled back easily.

@BilalQamar95 BilalQamar95 force-pushed the bilalqamar95/edx-ui-toolkit-upgrade branch from e46e9cb to eb17eec Compare September 6, 2023 08:44
@Mashal-m Mashal-m force-pushed the bilalqamar95/edx-ui-toolkit-upgrade branch 2 times, most recently from 16b02e1 to b660662 Compare October 24, 2023 10:15
@Mashal-m Mashal-m force-pushed the bilalqamar95/edx-ui-toolkit-upgrade branch 2 times, most recently from 388c1e6 to b94bcd5 Compare November 2, 2023 11:33
@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi force-pushed the bilalqamar95/edx-ui-toolkit-upgrade branch 10 times, most recently from 1bcdc8f to 823e267 Compare November 23, 2023 14:11
@BilalQamar95 BilalQamar95 force-pushed the bilalqamar95/edx-ui-toolkit-upgrade branch 2 times, most recently from e96d64e to 2114adf Compare November 27, 2023 12:30
@BilalQamar95 BilalQamar95 force-pushed the bilalqamar95/edx-ui-toolkit-upgrade branch from ebb9af5 to 6544d88 Compare November 28, 2023 09:29
@BilalQamar95 BilalQamar95 marked this pull request as ready for review November 28, 2023 15:14
Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BilalQamar95, do you mind adding some context as to why we're doing this? I'm not objecting, just curious.

Also, since @brian-smith-tcril is working on the Node 18 upgrade, this might have some bearing.

@@ -40,7 +40,7 @@
"datatables": "1.10.18",
"datatables.net-fixedcolumns": "3.2.6",
"edx-proctoring-proctortrack": "git+https://[email protected]/anupdhabarde/edx-proctoring-proctortrack.git#f0fa9edbd16aa5af5a41ac309d2609e529ea8732",
"edx-ui-toolkit": "1.5.4",
"edx-ui-toolkit": "github:openedx/edx-ui-toolkit",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we not publishing new versions of this automatically? Sounds like an issue in an of itself.

@feanil
Copy link
Contributor

feanil commented Jun 13, 2024

This is no longer necessary, I updated edx-ui-toolkit to a new version in #34873 that includes any changes that this was meant to capture. The new version previously couldn't be published to npm because it's ownership was not properly setup and it had no semantic release setup. I've fixed the permissions on the npmjs.org side and openedx/edx-ui-toolkit#413 will hopefully add auto-publishing so that we don't have to worry about this in the future.

@feanil feanil closed this Jun 13, 2024
@feanil feanil deleted the bilalqamar95/edx-ui-toolkit-upgrade branch June 13, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants