Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport: feat: add ability to notify credentials about honor certificates #32745

Conversation

DmytroAlipov
Copy link
Contributor

Description

backport from master

Honor mode is absent by default in the course list for "Program Records" that appears error for "Program Records" for users with permission "Active" after clicking on "View My Records" button:

screen_5

500 error appeared

Implemented:

  • Developed solution for adding course mode "Honor" to the list of modes for "Program Records"
  • "Earned" and "completed" status are set up for Honor Courses and Program after finishing the program for staff and particular user

Added a WaffleFlag course_modes.extend_certificate_relevant_modes_with_honor. When enabled - credential will receive data about the HONOR course certificates.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jul 14, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Jul 14, 2023

Thanks for the pull request, @DmytroAlipov! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate.

@mphilbrick211
Copy link

Hi @DmytroAlipov! Is this ready for review?

@DmytroAlipov
Copy link
Contributor Author

@mphilbrick211 yes )

@mphilbrick211 mphilbrick211 added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Jul 18, 2023
@mphilbrick211
Copy link

Hi @openedx/2u-aperture! Would someone be able to review/merge this for us? Thanks!

@jsnwesson
Copy link
Contributor

Hi @mphilbrick211 , I will be bringing this up with my team tomorrow morning!

@justinhynes
Copy link
Contributor

I added an internal ticket for tracking and prioritization purposes -- APER-2691.

@hurtstotouchfire
Copy link
Member

@mphilbrick211 Can we do a product review on this? I think honor certs are in a weird limbo in terms of support and we should come up with a more coherent plan.

@hurtstotouchfire
Copy link
Member

@mphilbrick211 Just kidding this is the backport. Let's have product review on #32633

@hurtstotouchfire hurtstotouchfire changed the title feat: add ability to notify credentials about honor certificates backport: feat: add ability to notify credentials about honor certificates Aug 30, 2023
@hurtstotouchfire hurtstotouchfire marked this pull request as draft August 30, 2023 14:19
@hurtstotouchfire
Copy link
Member

FYI @DmytroAlipov I'm converting this to a draft so it's not sitting in my triage queue, and you can update it once the main PR is merged.

@mphilbrick211 mphilbrick211 added product review PR requires product review before merging and removed waiting for eng review PR is ready for review. Review and merge it, or suggest changes. labels Aug 31, 2023
@mphilbrick211 mphilbrick211 added the backport PR backports a change from main to a named release. label Dec 15, 2023
@mariajgrimaldi
Copy link
Member

Since there will not be another release for palm, should we close this PR then?

@mphilbrick211 mphilbrick211 added product review complete PR has gone through product review and removed product review PR requires product review before merging labels Mar 29, 2024
@justinhynes
Copy link
Contributor

@DmytroAlipov I'm going to close this PR as any backports I believe should be going in Quince at this point in the release cycle. Feel free to disagree and reopen if you feel strongly about it 😂

@justinhynes justinhynes closed this Apr 3, 2024
@openedx-webhooks
Copy link

@DmytroAlipov Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

@DmytroAlipov DmytroAlipov deleted the notify-credentials-about-honor-certificates-palm branch April 3, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR backports a change from main to a named release. open-source-contribution PR author is not from Axim or 2U product review complete PR has gone through product review
Projects
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants