-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backport: feat: add ability to notify credentials about honor certificates #32745
Conversation
Thanks for the pull request, @DmytroAlipov! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate. |
Hi @DmytroAlipov! Is this ready for review? |
@mphilbrick211 yes ) |
Hi @openedx/2u-aperture! Would someone be able to review/merge this for us? Thanks! |
Hi @mphilbrick211 , I will be bringing this up with my team tomorrow morning! |
I added an internal ticket for tracking and prioritization purposes -- APER-2691. |
@mphilbrick211 Can we do a product review on this? I think honor certs are in a weird limbo in terms of support and we should come up with a more coherent plan. |
@mphilbrick211 Just kidding this is the backport. Let's have product review on #32633 |
FYI @DmytroAlipov I'm converting this to a draft so it's not sitting in my triage queue, and you can update it once the main PR is merged. |
Since there will not be another release for palm, should we close this PR then? |
@DmytroAlipov I'm going to close this PR as any backports I believe should be going in Quince at this point in the release cycle. Feel free to disagree and reopen if you feel strongly about it 😂 |
@DmytroAlipov Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
backport from master
Honor mode is absent by default in the course list for "Program Records" that appears error for "Program Records" for users with permission "Active" after clicking on "View My Records" button:
500 error appeared
Implemented:
Added a WaffleFlag course_modes.extend_certificate_relevant_modes_with_honor. When enabled - credential will receive data about the HONOR course certificates.