Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: remove unused update-assets-dev.sh #31810

Merged
merged 1 commit into from
Feb 22, 2023
Merged

refactor!: remove unused update-assets-dev.sh #31810

merged 1 commit into from
Feb 22, 2023

Conversation

kdmccormick
Copy link
Member

@kdmccormick kdmccormick commented Feb 22, 2023

Description

The file was introduced as part of the "decentralized devstack" spike. We wanted a working Dockerfile in the edx-platform root, and we wanted to speed it up by not relying on Paver.

edx-platform now has a working Dockerfile, and it does not use this script.

The paver-free-assets initiative is being continued here: #31798 It will result in a new, prod-ready script.

Other information

This helps with:

by reducing the number of shell scripts I need get passing ShellCheck.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
The file was introduced as part of a the "decentralized
devstack" spike in order to make a working paver-free Dockerfile
in the edx-platform root.

edx-platform now has a working Dockerfile, and it does
not use this script.

The paver-free-assets initiative is being continued here:
#31798
It will result in a new, prod-ready script.
@kdmccormick kdmccormick marked this pull request as ready for review February 22, 2023 02:10
@kdmccormick
Copy link
Member Author

kdmccormick commented Feb 22, 2023

Hey @dianakhuang @adzuci , bit of a throwback, but do either of you mind reviewing this?

Copy link
Contributor

@dianakhuang dianakhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@kdmccormick kdmccormick merged commit b140b7e into openedx:master Feb 22, 2023
@kdmccormick kdmccormick deleted the kdmccormick/rm-update-assets-dev branch February 22, 2023 15:29
@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

@kdmccormick kdmccormick mentioned this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants