Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tagging object rest api pagination #33311

Conversation

rpenido
Copy link
Contributor

@rpenido rpenido commented Sep 21, 2023

Description

Removes the pagination of the tagging REST API for listing and updating object tags.

Supporting Information

Testing instructions

  • Please ensure that the tests cover the expected behavior of the view as described in the related issue.

Private-ref: FAL-3501

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 21, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @rpenido! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

Copy link
Member

@yusuf-musleh yusuf-musleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I only reviewed the files related to removing the pagination from the rest api in this commit (19bb4c8ffb130f52e7b0a1bf3d7f10c9b98416c9). Since the rest of the changes seems to be related to previous work and would be rebased right @rpenido ?

  • I tested this: I read through the updated tests
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation
  • I made sure any change in configuration variables is reflected in the corresponding client's configuration-secure repository.

@rpenido rpenido force-pushed the rpenido/fal-3501-enforce-limit-on-number-of-tags-per-object branch from b314c1a to b8b1fa7 Compare September 22, 2023 11:36
@bradenmacdonald bradenmacdonald merged commit 64adc5e into openedx:master Sep 26, 2023
@bradenmacdonald bradenmacdonald deleted the rpenido/fal-3501-enforce-limit-on-number-of-tags-per-object branch September 26, 2023 17:48
@openedx-webhooks
Copy link

@rpenido 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tagging] Enforce limit on number of tags per object
5 participants