feat: remove object tagging rest api pagination

openedx · Sep 22, 2023 · b8b1fa7 · b8b1fa7
1 parent f9148f0
commit b8b1fa7
Show file tree

Hide file tree

Showing 7 changed files with 12 additions and 10 deletions.
diff --git a/openedx/core/djangoapps/content_tagging/rest_api/v1/tests/test_views.py b/openedx/core/djangoapps/content_tagging/rest_api/v1/tests/test_views.py
@@ -735,8 +735,9 @@ def test_tag_course(self, user_attr, taxonomy_attr, tag_values, expected_status)
 
         assert response.status_code == expected_status
         if status.is_success(expected_status):
-            assert len(response.data.get("results")) == len(tag_values)
-            assert set(t["value"] for t in response.data["results"]) == set(tag_values)
+            assert len(response.data) == len(tag_values)
+            assert set(t["value"] for t in response.data) == set(tag_values)
+
 
     @ddt.data(
         # Can't add invalid tags to a object using a closed taxonomy
@@ -803,8 +804,8 @@ def test_tag_xblock(self, user_attr, taxonomy_attr, tag_values, expected_status)
 
         assert response.status_code == expected_status
         if status.is_success(expected_status):
-            assert len(response.data.get("results")) == len(tag_values)
-            assert set(t["value"] for t in response.data["results"]) == set(tag_values)
+            assert len(response.data) == len(tag_values)
+            assert set(t["value"] for t in response.data) == set(tag_values)
 
     @ddt.data(
         # Can't add invalid tags to a object using a closed taxonomy

diff --git a/requirements/constraints.txt b/requirements/constraints.txt
@@ -128,7 +128,7 @@ click==8.1.6
 openedx-events<8.6.0               # Open edX Events from Hooks Extension Framework (OEP-50)
 
 # pinning this version to avoid updates while the library is being developed
-openedx-learning==0.1.6
+openedx-learning==0.1.7
 
 # lti-consumer-xblock 9.6.2 contains a breaking change that makes
 # existing custom parameter configurations unusable.

diff --git a/requirements/edx/base.txt b/requirements/edx/base.txt
@@ -790,7 +790,7 @@ openedx-filters==1.6.0
     # via
     #   -r requirements/edx/kernel.in
     #   lti-consumer-xblock
-openedx-learning==0.1.6
+openedx-learning @ git+https://github.com/open-craft/openedx-learning@rpenido/fal-3501-enforce-limit-on-number-of-tags-per-object
     # via
     #   -c requirements/edx/../constraints.txt
     #   -r requirements/edx/kernel.in

diff --git a/requirements/edx/development.txt b/requirements/edx/development.txt
@@ -1321,7 +1321,7 @@ openedx-filters==1.6.0
     #   -r requirements/edx/doc.txt
     #   -r requirements/edx/testing.txt
     #   lti-consumer-xblock
-openedx-learning==0.1.6
+openedx-learning @ git+https://github.com/open-craft/openedx-learning@rpenido/fal-3501-enforce-limit-on-number-of-tags-per-object
     # via
     #   -c requirements/edx/../constraints.txt
     #   -r requirements/edx/doc.txt

diff --git a/requirements/edx/doc.txt b/requirements/edx/doc.txt
@@ -928,7 +928,7 @@ openedx-filters==1.6.0
     # via
     #   -r requirements/edx/base.txt
     #   lti-consumer-xblock
-openedx-learning==0.1.6
+openedx-learning @ git+https://github.com/open-craft/openedx-learning@rpenido/fal-3501-enforce-limit-on-number-of-tags-per-object
     # via
     #   -c requirements/edx/../constraints.txt
     #   -r requirements/edx/base.txt

diff --git a/requirements/edx/kernel.in b/requirements/edx/kernel.in
@@ -116,7 +116,8 @@ openedx-calc                        # Library supporting mathematical calculatio
 openedx-django-require
 openedx-events                      # Open edX Events from Hooks Extension Framework (OEP-50)
 openedx-filters                     # Open edX Filters from Hooks Extension Framework (OEP-50)
-openedx-learning                    # Open edX Learning core (experimental)
+# openedx-learning                    # Open edX Learning core (experimental)
+openedx-learning @ git+https://github.com/open-craft/openedx-learning@rpenido/fal-3501-enforce-limit-on-number-of-tags-per-object # Remove this once openedx-learning is tagged
 openedx-mongodbproxy
 openedx-django-wiki
 openedx-blockstore

diff --git a/requirements/edx/testing.txt b/requirements/edx/testing.txt
@@ -998,7 +998,7 @@ openedx-filters==1.6.0
     # via
     #   -r requirements/edx/base.txt
     #   lti-consumer-xblock
-openedx-learning==0.1.6
+openedx-learning @ git+https://github.com/open-craft/openedx-learning@rpenido/fal-3501-enforce-limit-on-number-of-tags-per-object
     # via
     #   -c requirements/edx/../constraints.txt
     #   -r requirements/edx/base.txt