Skip to content

Commit

Permalink
style: rename add_tags_from_xml() to add_tags_from_field()
Browse files Browse the repository at this point in the history
  • Loading branch information
rpenido committed Mar 1, 2024
1 parent b98e2f8 commit a3b181e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion cms/djangoapps/contentstore/helpers.py
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,7 @@ def _import_xml_node_to_parent(
from cms.lib.xblock.tagging.tagged_block_mixin import TaggedBlockMixin
if isinstance(new_xblock, TaggedBlockMixin):
new_xblock.read_tags_from_node(node)
new_xblock.add_tags_from_xml()
new_xblock.add_tags_from_field()

return new_xblock

Expand Down
4 changes: 2 additions & 2 deletions cms/lib/xblock/tagging/tagged_block_mixin.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ def studio_post_duplicate(self, store, source_item):
if hasattr(source_item, 'serialize_tag_data'):
tags = source_item.serialize_tag_data()
self.tags_v1 = tags
self.add_tags_from_xml()
self.add_tags_from_field()

def serialize_tag_data(self):
"""
Expand Down Expand Up @@ -87,7 +87,7 @@ def read_tags_from_node(self, node):
if 'tags-v1' in node.attrib:
self.tags_v1 = str(node.attrib['tags-v1'])

def add_tags_from_xml(self):
def add_tags_from_field(self):
"""
Parse and add tag data from tags_v1 field
"""
Expand Down

0 comments on commit a3b181e

Please sign in to comment.