Skip to content

Commit

Permalink
build: run github actions on pull requests (#27786)
Browse files Browse the repository at this point in the history
  • Loading branch information
regisb authored Oct 4, 2021
1 parent 6ea900c commit 0af38bf
Show file tree
Hide file tree
Showing 2 changed files with 46 additions and 1 deletion.
43 changes: 43 additions & 0 deletions .github/workflows/ci-static-analysis.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
name: CI

on: pull_request

jobs:
tests:
name: Static analysis
runs-on: ${{ matrix.os }}
strategy:
matrix:
python-version: ['3.8']
os: ['ubuntu-20.04']

steps:
- uses: actions/checkout@v2
- name: Set up Python
uses: actions/setup-python@v2
with:
python-version: ${{ matrix.python-version }}

- name: Install system requirements
run: sudo apt update && sudo apt install -y libxmlsec1-dev

- name: Install pip
run: python -m pip install -r requirements/pip.txt

- name: Get pip cache dir
id: pip-cache-dir
run: echo "::set-output name=dir::$(pip cache dir)"

- name: Cache pip dependencies
id: cache-dependencies
uses: actions/cache@v2
with:
path: ${{ steps.pip-cache-dir.outputs.dir }}
key: ${{ runner.os }}-pip-${{ hashFiles('requirements/edx/development.txt') }}
restore-keys: ${{ runner.os }}-pip-

- name: Install python dependencies
run: pip install -r requirements/edx/development.txt

- name: Static code analysis
run: make check-types
4 changes: 3 additions & 1 deletion openedx/core/djangoapps/content/learning_sequences/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@
from rest_framework.response import Response
from rest_framework.views import APIView

from openedx.core import types
from openedx.core.lib.api.view_utils import validate_course_key

from .api import get_user_course_outline_details
from .api.permissions import can_call_public_api, can_see_content_as_other_users
from .data import CourseOutlineData
Expand Down Expand Up @@ -185,7 +187,7 @@ def get(self, request, course_key_str, format=None): # lint-amnesty, pylint: di
serializer = self.UserCourseOutlineDataSerializer(user_course_outline_details)
return Response(serializer.data)

def _determine_user(self, request, course_key: CourseKey) -> User:
def _determine_user(self, request, course_key: CourseKey) -> types.User:
"""
For which user should we get an outline?
Expand Down

0 comments on commit 0af38bf

Please sign in to comment.