fix: drop python 3.8 support

.github/workflows/ci.yml

@@ -14,7 +14,7 @@ jobs:
       fail-fast: false
       max-parallel: 4
       matrix:
-        python-version: ['py38', 'py311', 'py312']
+        python-version: ['py311', 'py312']
         django-version: ['django42']
         db-version: ['mysql80']
 

.github/workflows/migrations-mysql8-check.yml

@@ -15,7 +15,7 @@ jobs:
       fail-fast: false
       matrix:
         os: [ ubuntu-20.04 ]
-        python-version: [ '3.8', '3.11', '3.12' ]
+        python-version: [ '3.11', '3.12' ]
 
     steps:
     - name: Checkout repo

notesapi/v1/tests/test_views.py

@@ -388,14 +388,9 @@ def test_read_all_no_annotations(self):
         headers["course_id"] = "a/b/c"
         response = self.client.get(reverse('api:v1:annotations'), headers)
         self.assertEqual(response.status_code, status.HTTP_200_OK)
-        if sys.version_info[1] == 12:  # python 3.12
-            self.assertEqual(
-                {'total': 0, 'rows': []} | response.data, response.data, "no annotation should be returned in response"
-            )
-        else:  # remove this code after removing python 3.8 dependency
-            self.assertDictContainsSubset(
-                {'total': 0, 'rows': []}, response.data, "no annotation should be returned in response"
-            )
+        self.assertEqual(
+            {'total': 0, 'rows': []} | response.data, response.data, "no annotation should be returned in response"
+        )
 
     def test_read_all(self):
         """

tox.ini

@@ -1,5 +1,5 @@
 [tox]
-envlist = py{38,311,312}-django{42}
+envlist = py{311,312}-django{42}
 skipsdist = true
 
 [testenv]