feat: add python 3.12 support #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BilalQamar95
force-pushed
the
bilalqamar95/python-upgrade
branch
from
63ba2da to
e2cb748
Compare
UsamaSadiq
requested changes
Oct 22, 2024
| @@ -267,6 +267,7 @@ def _verify_jwt_signature(token, jwt_issuer, decode_symmetric_token): | |||
| raise jwt.InvalidTokenError(exc_info[2]) from token_error | |||
|
|
|||
|
|
|||
| # pylint: disable=R0917 | |||
There was a problem hiding this comment.
Is this one still needed after updating pylintrc?
There was a problem hiding this comment.
Yes, it suppresses too-many-positional-arguments error.
There was a problem hiding this comment.
Let's add too-many-positional-arguments in pylintrc_tweaks disable section instead of within the file.
UsamaSadiq
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For details, see tracking issue #481