feat: Add root span tagging for exceptions. #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dianakhuang
force-pushed
the
diana/add-error-tagging
branch
5 times, most recently
from
f1393a2 to
5fd9fe1
Compare
robrap
reviewed
Sep 30, 2024
dianakhuang
force-pushed
the
diana/add-error-tagging
branch
from
b03ee8e to
0dc18b1
Compare
robrap
reviewed
Oct 1, 2024
dianakhuang
force-pushed
the
diana/add-error-tagging
branch
from
a559140 to
9c1f532
Compare
Datadog has issues with tagging the root span with error information. This change adds the functionality to tag the root span on exceptions. This also renames the CachedCustomMonitoringMiddleware into MonitoringSupportMiddleware so that it can be a central place for most monitoring middleware changes instead of adding a new one every time. At some point, CachedCustomMonitoringMiddleware will be removed. edx/edx-arch-experiments#647
dianakhuang
force-pushed
the
diana/add-error-tagging
branch
from
9c1f532 to
9342700
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Datadog has issues with tagging the root span
with error information. This change adds the functionality
to tag the root span on exceptions.
This also renames the CachedCustomMonitoringMiddleware into
MonitoringSupportMiddleware so that it can be a central place
for most monitoring middleware changes instead of adding a new
one every time. At some point, CachedCustomMonitoringMiddleware
will be removed.
edx/edx-arch-experiments#647