Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix read-the-doc-link #194

Closed

Conversation

src-r-r
Copy link
Contributor

@src-r-r src-r-r commented Jan 13, 2022

For issue #143.

Correct URL is "https://django-config-models.readthedocs.io/en/latest/"

Verified by pushing the branch and checking the link.

@openedx-webhooks
Copy link

Thanks for the pull request, @src-r-r! I've created OSPR-6387 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

⚠️ We can't start reviewing your pull request until you've submitted a signed contributor agreement or indicated your institutional affiliation. Please see the CONTRIBUTING file for more information. If you've signed an agreement in the past, you may need to re-sign. See The New Home of the Open edX Codebase for details.

@natabene
Copy link

@src-r-r Thank you for the contribution! Once you have signed our Contributor Agreement and it has been processed, you will receive a confirmation via email from our Legal team. We then will be able to review this and all your future code contributions.

@codecov
Copy link

codecov bot commented Jan 14, 2022

Codecov Report

Merging #194 (cd7ef20) into master (9c283d7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #194   +/-   ##
=======================================
  Coverage   89.39%   89.39%           
=======================================
  Files           9        9           
  Lines         198      198           
  Branches       35       35           
=======================================
  Hits          177      177           
  Misses         17       17           
  Partials        4        4           
Flag Coverage Δ
unittests 89.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c283d7...cd7ef20. Read the comment docs.

@natabene
Copy link

@src-r-r We have not heard from you in a while, so I will close this PR for now. Please feel free to re-open, should you decide to pursue this again.

@openedx-webhooks
Copy link

@src-r-r Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

@src-r-r
Copy link
Contributor Author

src-r-r commented Feb 16, 2022

@natabene Ah, sorry about that. I haven't gotten notifications in time about stuff on GitHub so I've fallen behind. I'll get it taken care of this morning.

@natabene
Copy link

@src-r-r No worries, thanks for looking into this. Please ping me here once you are done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U rejected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants