-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paragon StatusAlert deprecation #1692
Paragon StatusAlert deprecation #1692
Conversation
… updated unit tests
…d updated unit tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a fine change - the owning team should also review so they're aware of the change, it should be tested by Fed-BOM and we can get it in. I did a cursory review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, I checked it locally and noticed that the Dismiss
button text seems larger than expected. It seems very large compared to the examples from Paragon. Is there anyway to adjust that?
@abdullahwaheed -- quick question on the size of the Dismiss button before accepting this change. Thanks for the help and let me know what you think! |
@justinhynes |
@abdullahwaheed Is this ready for another look too? Or is this still being worked on? |
@justinhynes need some changes from #1691. Will update it once its merged |
@justinhynes its ready for review, kindly test it again |
@abdullahwaheed I am still seeing a button size discrepancy between the |
@abdullahwaheed Thanks for the update. Something might not quite be right in my local environment. Based on your screenshots I think this is good to go. |
Ticket
Migrate off deprecated Paragon components
What has changed
Removed deprecated
StatusAlert
component of paragon and updated it withAlert
References
Paragon StatusAlert
Paragon Alert