Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paragon StatusAlert deprecation #1692

Merged
merged 8 commits into from
Jul 27, 2022

Conversation

abdullahwaheed
Copy link
Contributor

Ticket

Migrate off deprecated Paragon components

What has changed

Removed deprecated StatusAlert component of paragon and updated it with Alert

References

Paragon StatusAlert
Paragon Alert

@abdullahwaheed abdullahwaheed self-assigned this Jun 20, 2022
Copy link

@davidjoy davidjoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a fine change - the owning team should also review so they're aware of the change, it should be tested by Fed-BOM and we can get it in. I did a cursory review.

@justinhynes
Copy link
Contributor

Screenshots before and after the change...

Before
image

After
image

Copy link
Contributor

@justinhynes justinhynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, I checked it locally and noticed that the Dismiss button text seems larger than expected. It seems very large compared to the examples from Paragon. Is there anyway to adjust that?

@justinhynes
Copy link
Contributor

@abdullahwaheed -- quick question on the size of the Dismiss button before accepting this change. Thanks for the help and let me know what you think!

@abdullahwaheed
Copy link
Contributor Author

@justinhynes .btn styling was affecting its font, removed this to make it consistent with library

@justinhynes
Copy link
Contributor

I think this change is also having conflicts with the edx.org theme. :(

In the openedx theme the button size looks right:
image

In the edx.org theme the button size is unchanged:
image

Sorry :(

@jmbowman jmbowman added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Jul 25, 2022
@justinhynes
Copy link
Contributor

@abdullahwaheed Is this ready for another look too? Or is this still being worked on?

@abdullahwaheed
Copy link
Contributor Author

@justinhynes need some changes from #1691. Will update it once its merged

@abdullahwaheed
Copy link
Contributor Author

@justinhynes its ready for review, kindly test it again

@justinhynes
Copy link
Contributor

@abdullahwaheed I am still seeing a button size discrepancy between the openedx and edx.org themes:

openedx:
image

edx.org:
image

@abdullahwaheed
Copy link
Contributor Author

I have tested it on edx.org theme and override styles are working.
image

@justinhynes
Copy link
Contributor

@abdullahwaheed Thanks for the update. Something might not quite be right in my local environment. Based on your screenshots I think this is good to go.

@abdullahwaheed abdullahwaheed merged commit 6774165 into master Jul 27, 2022
@abdullahwaheed abdullahwaheed deleted the abdullah/paragon-statusalert-deprecation branch July 27, 2022 13:32
@jmbowman jmbowman removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants