Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Review fix of un-imported Content of Common Cartridge to OLX #143

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

FahadKhalid210
Copy link

Fix un-imported contents

Fixes:

  • Successfully imported the learning-application-resource type when the file suffix is ".html".
  • Fixed html of images that are not in web_resources
  • Added the static files from the resources directory into the static directory.
  • Resolved the errors related to KeyError and AttributeError.

@FahadKhalid210
Copy link
Author

@MichaelRoytman @alangsto @ilee2u
Kindly review this PR.
Thanks

@FahadKhalid210 FahadKhalid210 changed the title Review fix of un-imported Content of Common Cartridge to OLX Fix: Review fix of un-imported Content of Common Cartridge to OLX Jun 7, 2023
@FahadKhalid210 FahadKhalid210 changed the title Fix: Review fix of un-imported Content of Common Cartridge to OLX fix: Review fix of un-imported Content of Common Cartridge to OLX Jun 7, 2023
@alangsto
Copy link
Contributor

alangsto commented Jun 7, 2023

Hi @FahadKhalid210, our team has been notified and will prioritize reviewing this PR accordingly.

@ziafazal ziafazal requested a review from MichaelRoytman June 6, 2024 06:09
@ziafazal
Copy link

ziafazal commented Jun 6, 2024

@MichaelRoytman could you please review this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants