-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update our browserslist config per "Best Practices" #16
Conversation
Thanks for the pull request, @bradenmacdonald! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently unmaintained. To get help with finding a technical reviewer, tag the community contributions project manager for this PR in a comment and let them know that your changes are ready for review:
Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
5564cc9
to
5b7bbeb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼
Something went wrong with the |
I retried the job and it looks like it worked this time. |
Hmm, so on the re-run it didn't find any changes which is why it passed. It seems publishing to The latest GH release is from April 2023 https://github.com/openedx/browserslist-config/releases/tag/v1.2.0 The latest |
Made an issue for the GH releases failing #17 |
Do we really use/need the GitHub release? |
We don't need them, but the automatic changelogs in there can be nice. |
Our browserslist config is currently not following the Best Practices that the browserslist project recommends.
In particular, they say:
Here is the list of supported browsers (from
npm run supported
), before and after this change:I don't have a strong opinion on this change, but I do think it makes sense to follow the best practices if there's little or no cost to doing so.