feat: Fix quality tests failures

xblock/test/utils/test_helpers.py

@@ -10,16 +10,19 @@
 from xblock.utils.helpers import child_isinstance
 
 
+# pylint: disable=unnecessary-pass
 class DogXBlock(XBlock):
     """ Test XBlock representing any dog. Raises error if instantiated. """
     pass
 
 
+# pylint: disable=unnecessary-pass
 class GoldenRetrieverXBlock(DogXBlock):
     """ Test XBlock representing a golden retriever """
     pass
 
 
+# pylint: disable=unnecessary-pass
 class CatXBlock(XBlock):
     """ Test XBlock representing any cat """
     pass
@@ -38,6 +41,7 @@ class TestChildIsInstance(unittest.TestCase):
     @XBlock.register_temp_plugin(GoldenRetrieverXBlock, "gr")
     @XBlock.register_temp_plugin(CatXBlock, "cat")
     @XBlock.register_temp_plugin(BasicXBlock, "block")
+    # pylint: disable=W0201
     def test_child_isinstance(self):
         """
         Check that child_isinstance() works on direct children
@@ -60,6 +64,7 @@ def test_child_isinstance(self):
     @XBlock.register_temp_plugin(GoldenRetrieverXBlock, "gr")
     @XBlock.register_temp_plugin(CatXBlock, "cat")
     @XBlock.register_temp_plugin(BasicXBlock, "block")
+    # pylint: disable=W0201
     def test_child_isinstance_descendants(self):
         """
         Check that child_isinstance() works on deeper descendants

xblock/test/utils/test_publish_event.py

@@ -1,3 +1,6 @@
+"""
+Test cases for xblock/utils/publish_event.py
+"""
 #
 # Copyright (C) 2014-2015 edX
 #
@@ -53,6 +56,9 @@ class ObjectUnderTest(XBlockMock, PublishEventMixin):
 
 
 class TestPublishEventMixin(unittest.TestCase):
+    """
+    Test cases for PublishEventMixin
+    """
     def assert_no_calls_made(self, block):
         self.assertFalse(block.last_call)
 

xblock/test/utils/test_resources.py

@@ -1,5 +1,5 @@
 """
-Tests for helpers.py
+Tests for resources.py
 """
 
 #
@@ -168,12 +168,16 @@ def __getattr__(self, name):
 
 
 class TestResourceLoader(unittest.TestCase):
+    """
+    Unit Tests for ResourceLoader
+    """
+
     def test_load_unicode(self):
         s = ResourceLoader(__name__).load_unicode("data/simple_django_template.txt")
         self.assertEqual(s, expected_string)
 
     def test_load_unicode_from_another_module(self):
-        s = ResourceLoader("xblock.test.utils.unit.data").load_unicode("simple_django_template.txt")
+        s = ResourceLoader("xblock.test.utils.data").load_unicode("simple_django_template.txt")
         self.assertEqual(s, expected_string)
 
     def test_render_django_template(self):

xblock/test/utils/test_settings.py

@@ -1,3 +1,6 @@
+"""
+Test cases for xblock/utils/settings.py
+"""
 import itertools
 import unittest
 from unittest.mock import Mock, MagicMock, patch
@@ -10,6 +13,9 @@
 
 @XBlock.wants('settings')
 class DummyXBlockWithSettings(XBlock, XBlockWithSettingsMixin, ThemableXBlockMixin):
+    """
+    A dummy XBlock test class provides configurable theme support via Settings Service
+    """
     block_settings_key = 'dummy_settings_bucket'
     default_theme_config = {
         'package': 'xblock_utils',
@@ -19,6 +25,9 @@ class DummyXBlockWithSettings(XBlock, XBlockWithSettingsMixin, ThemableXBlockMix
 
 @XBlock.wants('settings')
 class OtherXBlockWithSettings(XBlock, XBlockWithSettingsMixin, ThemableXBlockMixin):
+    """
+    Another XBlock test class provides configurable theme support via Settings Service
+    """
     block_settings_key = 'other_settings_bucket'
     theme_key = 'other_xblock_theme'
     default_theme_config = {
@@ -29,6 +38,9 @@ class OtherXBlockWithSettings(XBlock, XBlockWithSettingsMixin, ThemableXBlockMix
 
 @ddt.ddt
 class TestXBlockWithSettingsMixin(unittest.TestCase):
+    """
+    Test cases for XBlockWithSettingsMixin
+    """
     def setUp(self):
         self.settings_service = Mock()
         self.runtime = Mock()
@@ -55,7 +67,10 @@ def test_invokes_get_settings_bucket_and_returns_result(self, block, settings_se
 
 
 @ddt.ddt
-class TextThemableXBlockMixin(unittest.TestCase):
+class TestThemableXBlockMixin(unittest.TestCase):
+    """
+    Test cases for ThemableXBlockMixin
+    """
     def setUp(self):
         self.service_mock = Mock()
         self.runtime_mock = Mock()

xblock/utils/settings.py

@@ -23,7 +23,7 @@ class XBlockWithSettingsMixin:
 
     def get_xblock_settings(self, default=None):
         """
-        Gets XBlock-specific settigns for current XBlock
+        Gets XBlock-specific settings for current XBlock
 
         Returns default if settings service is not available.