Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RecommenderXBlock: Drop py3.8 support | Replace pkg_resources lib with importlib.resources #98

Merged
merged 6 commits into from
Oct 25, 2024

Conversation

beingfaisal
Copy link
Contributor

@beingfaisal beingfaisal commented Sep 9, 2024

Issue - Move on from deprecated pkg_resources api
Issue - Drop Python 3.8 & Add Support for Python 3.12

  • Drop python 3.8 support and add support for python 3.12
  • Replace pkg_resources with importlib

Screenshots
Screenshot 2024-09-10 at 1 05 41 PM
Screenshot 2024-09-10 at 1 06 17 PM

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 9, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @beingfaisal!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Submit a signed contributor agreement (CLA)

⚠️ We ask all contributors to the Open edX project to submit a signed contributor agreement or indicate their institutional affiliation.
Please see the CONTRIBUTING file for more information.

If you've signed an agreement in the past, you may need to re-sign.
See The New Home of the Open edX Codebase for details.

Once you've signed the CLA, please allow 1 business day for it to be processed.
After this time, you can re-run the CLA check by adding a comment below that you have signed it.
If the CLA check continues to fail, you can tag the @openedx/cla-problems team in a comment for further assistance.

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @navinkarkera. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@mphilbrick211
Copy link

Hi @beingfaisal! Thanks for this contribution! If you are contributing on behalf of edly, please have your manager reach out to [email protected] to add you to our existing agreement. Thanks!

@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Sep 9, 2024
@farhan
Copy link

farhan commented Sep 11, 2024

@beingfaisal All seems ok to me, but will be great to cover following issue within this PR and add support of Python 3.12
#100

Copy link

@farhan farhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requrest an addition

@e0d
Copy link

e0d commented Sep 24, 2024

@beingfaisal are you on the Arbisoft team?

@e0d
Copy link

e0d commented Sep 24, 2024

@beingfaisal looks like your branch needs some conflicts resolved, can you have a look? Otherwise the checks are all passing.

@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Sep 24, 2024
@beingfaisal beingfaisal force-pushed the faisal/pkg_resource_update branch from 159ea8c to 98b9851 Compare September 25, 2024 06:15
Copy link

@farhan farhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 change

@@ -16,7 +16,7 @@ jobs:
matrix:
os:
- ubuntu-latest
python-version: ['3.8', '3.11']
python-version: ['3.11']
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@beingfaisal Please add support of 3.12 as well, change to
python-version: ['3.11', '3.12']

recommender/__init__.py Outdated Show resolved Hide resolved
@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Oct 24, 2024
@feanil feanil merged commit 26cad98 into openedx:master Oct 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs test run Author's first PR to this repository, awaiting test authorization from Axim open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants