This repository has been archived by the owner on May 1, 2024. It is now read-only.
Python Requirements Update #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
List of packages in the PR without any issue.
|
|
These Packages need manual review..
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #690 +/- ##
=======================================
Coverage 97.51% 97.51%
=======================================
Files 53 53
Lines 3023 3023
Branches 266 266
=======================================
Hits 2948 2948
Misses 63 63
Partials 12 12 ☔ View full report in Codecov by Sentry. |
MichaelRoytman
force-pushed
the
jenkins/upgrade-python-requirements-09a8301
branch
3 times, most recently
from
780624d to
3c9d63a
Compare
False was the default value for navigation_with_keys. However, in version 0.14.2 of pydata-sphinx-theme, this default was removed and a warning was added that would be emitted whenever navigation_with_keys was not set. Because of the "SPHINXOPTS = -W" configuration in tox.ini, all warnings are promoted to an error. Therefore, it's necesary to set this value. I have set it to the default value explicitly. Please see the following GitHub comments for context. * pydata/pydata-sphinx-theme#1539 * pydata/pydata-sphinx-theme#987 (comment)
MichaelRoytman
force-pushed
the
jenkins/upgrade-python-requirements-09a8301
branch
from
054d560 to
f4e5823
Compare
MichaelRoytman
approved these changes
Oct 30, 2023
MichaelRoytman
deleted the
jenkins/upgrade-python-requirements-09a8301
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python requirements update. Please review the changelogs for the upgraded packages.
Deleted obsolete pull_requests:
#689