Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

chore: remove bok-choy usage #1527

Merged

Conversation

salman2013
Copy link
Contributor

Description:

As the bok-choy has been deprecated openedx/public-engineering#13, we are removing its usage from the code in this PR.

Ticket : https://github.com/orgs/openedx/projects/55/views/1?pane=issue&itemId=43871848

@salman2013 salman2013 marked this pull request as ready for review November 10, 2023 09:59
@salman2013 salman2013 requested review from farhan and feanil November 10, 2023 10:21
Copy link
Contributor

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some more mixins in the acceptance test module that should also be cleaned up because they are no longer being used anywhere but other than that this looks good.

acceptance_tests/mixins.py Outdated Show resolved Hide resolved
@salman2013 salman2013 requested a review from feanil November 14, 2023 17:24
Copy link
Contributor

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed one more thing but then I think this is good to go.

@@ -4,7 +4,6 @@
-r base.txt

astroid
bok-choy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need selenium in this repo or should that be removed as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not, i searched and removed it. thanks for pointing this.

@salman2013 salman2013 requested a review from feanil November 15, 2023 07:08
@feanil feanil merged commit cc4b4bb into openedx-unsupported:master Nov 16, 2023
4 checks passed
@feanil feanil mentioned this pull request Dec 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants