This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
feat: Add Dynamic Payment Methods BNPL #4115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianajlk
force-pushed
the
julianajlk/REV-3821/stripe-dpm
branch
5 times, most recently
from
5c892f0 to
438ba64
Compare
julianajlk
force-pushed
the
julianajlk/REV-3821/stripe-dpm
branch
9 times, most recently
from
54ecc61 to
292a76b
Compare
julianajlk
force-pushed
the
julianajlk/REV-3821/stripe-dpm
branch
3 times, most recently
from
f49b2ed to
49c6cf3
Compare
julianajlk
force-pushed
the
julianajlk/REV-3821/stripe-dpm
branch
11 times, most recently
from
949bee5 to
238675a
Compare
julianajlk
force-pushed
the
julianajlk/REV-3821/stripe-dpm
branch
4 times, most recently
from
b9e948b to
5f2afe8
Compare
julianajlk
commented
Apr 2, 2024
julianajlk
commented
Apr 2, 2024
zubair-ce07
reviewed
Apr 8, 2024
| ) | ||
| except stripe.error.CardError as err: | ||
| self.record_processor_response(err.json_body, transaction_id=payment_intent_id, basket=basket) | ||
| logger.exception('Card Error for basket [%d]: %s}', basket.id, err) | ||
| raise | ||
|
|
||
| # If the payment has another status other than 'succeeded', we want to return to the MFE something it can handle | ||
| if dynamic_payment_methods_enabled: | ||
| if confirm_api_response['status'] == 'requires_action': |
There was a problem hiding this comment.
is it possible that the status would not be succeeded AND not be requires_action?
There was a problem hiding this comment.
I don't think so at this point in the code in the POST request? But I will think about this
This was referenced Apr 9, 2024
julianajlk
force-pushed
the
julianajlk/REV-3821/stripe-dpm
branch
from
71feaae to
95fca20
Compare
christopappas
approved these changes
Apr 12, 2024
…rogressProcessorResponse
julianajlk
force-pushed
the
julianajlk/REV-3821/stripe-dpm
branch
from
95fca20 to
be962ab
Compare
julianajlk
force-pushed
the
julianajlk/REV-3821/stripe-dpm
branch
from
6d279c8 to
9e69195
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REV-3821.
Legacy uses Custom Actions Beta (CAB), which do not have
automatic_payment_methodsenabled by default in Stripe.In preparation for the DPM experiment, we need to refactor our code in ecommerce and payment MFE to be able to handle a different payment flow.
A note on server/client side confirmation with DPM and redirect to receipt:
The docs for dynamic payment methods use client-side Payment Intent confirmation, and even though with CAB we can confirm the Payment Intent server-side, the "next action" is still handled from the client.
This means that on "Place Order" in the payment MFE, we make a
POSTrequest to ecommerce to confirm the Payment Intent (among other things), but this is not finalized until we're back in the MFE after a re-direct from the BNPL environment.This means that it would skip order and billing address creation and order fulfillment in ecommerce, and the redirect to the receipt page would have to happen from the MFE to an order that doesn't exist yet --> we will use webhooks to make this happen async, included in this PR.