This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
docs: updated readme for 2u/release contributions #3927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nedbat
reviewed
Mar 17, 2023
nedbat
reviewed
Mar 23, 2023
nedbat
reviewed
Mar 23, 2023
nedbat
approved these changes
May 1, 2023
nedbat
approved these changes
Dec 4, 2023
julianajlk
approved these changes
Dec 4, 2023
| breaking functionality for 2U or 2U committing changes to "master" that are irrelevant or | ||
| otherwise inappropriate for the community's use case. | ||
|
|
||
| Because protected branches in ecommerce require a user with Write access to the repository, |
There was a problem hiding this comment.
Could we add this information to the README? I am not sure it's clear master will now only rely on community review only. We could separate the "How to Contribute" section into Open Source and 2U contributions
There was a problem hiding this comment.
For what it's worth, how the community wants to interact with ecommerce is actually still an open question (most likely for Axim) that has been raised already. I'm not sure I could really add specifics around community review and master other than "2U wont be doing it" 🤔
christopappas
force-pushed
the
wrussell/REV-3282-readme
branch
3 times, most recently
from
a12d8e6 to
780e0c5
Compare
fix: changed branch name from 2u/release to 2u/main fix: updated readme syntax docs: update PR template docs: add decision record for master branch split Update docs/decisions/0008-master-branch-split.rst Co-authored-by: Ned Batchelder <[email protected]> Update docs/decisions/0008-master-branch-split.rst Co-authored-by: Ned Batchelder <[email protected]> docs: feedback Update docs/decisions/0008-master-branch-split.rst Co-authored-by: Ned Batchelder <[email protected]> docs: update a link chore: adding back link change i clobbered by accident docs: use correctly cased branch in heading
christopappas
force-pushed
the
wrussell/REV-3282-readme
branch
from
780e0c5 to
83bf32c
Compare
christopappas
pushed a commit
to christopappas/ecommerce
that referenced
this pull request
Dec 5, 2023
…d#3927) docs: add decision record for master branch split
christopappas
added a commit
that referenced
this pull request
Dec 5, 2023
* docs: updated readme for 2u/release contributions (#3927) * fix: update ci GHA to use 2u/main instead of 2u/release --------- Co-authored-by: wdrussell2015 <[email protected]>
zubair-ce07
added a commit
that referenced
this pull request
Jan 16, 2024
feat: resloved reserved keywords conflict feat: add data mmigration to make basket_lineattribute value json compatible docs: updated readme for 2u/release contributions (#3927) docs: add decision record for master branch split feat: add atlas pull support (#4051) Refs: FC-0012 OEP-58 feat: added refund functionality
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛔️ DEPRECATION WARNING
This repository is deprecated and in maintainence-only operation while we work on a replacement, please see this announcement for more information.
Although we have stopped integrating new contributions, we always appreciate security disclosures and patches sent to [email protected]
Anyone internally merging to this repository is expected to release and monitor their changes; if you are not able to do this DO NOT MERGE, please coordinate with someone who can to ensure that the changes are released.
Required Testing
(^ We can remove that manual check once REV-2624 is done and the corresponding e2e test runs again)
Description
Describe what this pull request changes, and why these changes were made. How will these changes affect other people, installations of edx, etc.?
Please include links to any relevant ADRs, design artifacts, and decision documents. Make sure to document the rationale behind significant changes in the repo, per OEP-19, and can be
linked here.
Useful information to include:
Supporting information
Link to other information about the change, such as Jira issues, GitHub issues, or Discourse discussions.
Be sure to check they are publicly readable, or if not, repeat the information here.
Testing instructions
Please provide detailed step-by-step instructions for testing this change; how did YOU test this change?
Other information
Include anything else that will help reviewers and consumers understand the change.