Remove shinywidgets #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekraffmiller
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
Looks good, there is a question about if/how we want to manage dependencies for installation, a separate issue for that is here #60
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had introduced this dependency copy-and-pasting from tutorials, but we don't need it, and may never need it. It allows interactive widgets designed for Jupiter to work in Shiny.
Even if they come for free, I'm inclined to keep interactive visualizations out of this project. Producing PDFs at some point isn't unlikely, and dealing with interactive visualizations would be a distraction.