Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused sort #206

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Remove unused sort #206

merged 1 commit into from
Jan 7, 2025

Conversation

mccalluc
Copy link
Contributor

@mccalluc mccalluc commented Dec 19, 2024

move it out of the code, but add it to the doctest for stability.

Copy link
Member

@ekraffmiller ekraffmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. When testing I noticed an issue with the display of the histogram in the notebook, added an issue here.

@mccalluc mccalluc merged commit 4c217fb into main Jan 7, 2025
2 checks passed
@mccalluc mccalluc deleted the 178-no-sort-after-collect branch January 7, 2025 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Remove sort after collect
2 participants