Hello world! #2
Merged
Hello world! #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mccalluc
commented
Sep 18, 2024
•
mccalluc
commented
- Fix Hello world #1
There was a problem hiding this comment.
I see that @Shoeboxam is the reviewer for this, thank you Mike! I just wanted to comment that I downloaded the repo and built the app and ran the tests, everything worked fine. I have some questions about the the templates and converters, but these look like they are still in the experimental stage.
ekraffmiller
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
I discussed my questions with @mccalluc. Looks good to me, approving
This was referenced Sep 26, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.