Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

warn about breakpoint in playwright #198

Merged
merged 5 commits into from
Dec 10, 2024
Merged

warn about breakpoint in playwright #198

merged 5 commits into from
Dec 10, 2024

Conversation

mccalluc
Copy link
Contributor

@mccalluc mccalluc commented Dec 5, 2024

@ChengShi-1 ChengShi-1 self-requested a review December 9, 2024 15:27
ChengShi-1
ChengShi-1 approved these changes Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@ChengShi-1 ChengShi-1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

visually inspect the code, and run the test successfully. It makes sense to give the warning. Approve.

@mccalluc mccalluc merged commit 6a0bda8 into main Dec 10, 2024
2 checks passed
@mccalluc mccalluc deleted the 193-suggest-page-pause branch December 10, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChengShi-1 ChengShi-1 ChengShi-1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
DP Wizard
Status: Complete
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

In playwright tests, use page.pause()
2 participants
@mccalluc @ChengShi-1