Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let user set number of rows in simulated data #183

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

mccalluc
Copy link
Contributor

@mccalluc mccalluc commented Nov 24, 2024

For the reviewer:

  • Does the introduction to this option make sense?
  • Is this a good set of choices? I was hoping that thinking in terms of orders of magnitude lessens the pressure on the user when coming up with an estimate, and that 10 is too small to be useful, while 100,000 is so large that the improvement is negligible, leaving us with 100, 1,000, and 10,000.

@ChengShi-1 ChengShi-1 self-assigned this Nov 25, 2024
@ChengShi-1 ChengShi-1 self-requested a review November 25, 2024 20:44
Copy link
Collaborator

@ChengShi-1 ChengShi-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no problem with 100, 1,000, and 10,000. Just an idea. It may be cleaner for users if we could make the selection a range instead of a number? Selections may look like 10-100, 100-1000, 1000-10,000 or something like these.

@mccalluc
Copy link
Contributor Author

I don't think that would be more clear.

  • It is selecting one particular number: With 100, the simulated dataset has 100 rows, ditto for 1000 and 10000. It's not clear to me whether "100-1000" would be better represented by 100, or 1000, or something in between.
  • I want to take the pressure off the user for knowing how many rows are in their dataset. Ideally they don't even look at their data. I worry that putting a range on it will make them think that they should know which range their data is in.

@mccalluc mccalluc requested a review from ChengShi-1 November 25, 2024 22:23
Copy link
Collaborator

@ChengShi-1 ChengShi-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visually reviewed the code, and run it as well. Approve cause everything works well

@mccalluc mccalluc merged commit 006643a into main Nov 26, 2024
2 checks passed
@mccalluc mccalluc deleted the 154-control-number-of-rows-in-fake branch November 26, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Does the number of rows in the fake data impact visualization?
2 participants