-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Text (yaml) report for download #181
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the report, it looks good, but I think it would be helpful for the user if all the imports for the release were listed.
For example, this is the generated report I got:
inputs:
data: /var/folders/sv/ps25r8d562z0jzv4y4c_yn7c0000gq/T/fileupload-f2gfx9jw/tmppn4cvg9x/0.csv
outputs:
educ:
accuracy: 3.375617766595713
confidence: 0.95
histogram:
(-inf, 1]: 33
(1, 2.5]: 14
(10, 11.5]: 167
(11.5, 13]: 254
(13, 14.5]: 53
(14.5, 16]: 36
(2.5, 4]: 57
(4, 5.5]: 24
(5.5, 7]: 54
(7, 8.5]: 47
(8.5, 10]: 261
I think it would be good to also include, the epsilon, weight, and maybe number of bins? (Although that is shown in the actual result)
* use original column names in our report * flatten util * checkpoint on CSV report; tests not passing * csv report works * add a test * button grid * factor out button function * update test to match
I think this adds all the required info, but we're just inserting the values into the generated code: The values also occur earlier in the template, but they aren't stored into variables. Doing that would add a level of generality that would interfere with the clarity of the examples at the top of the notebook, which I think are the priority... but I could be wrong. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it looks good, I agree that you don't need to change the notebook to put the values into variables.
For reviewer: