Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add odrcore/4.1.0 #12

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Add odrcore/4.1.0 #12

merged 1 commit into from
Jul 31, 2024

Conversation

ViliusSutkus89
Copy link
Contributor

Hey @andiwand , does 4.1.0 need any patches? I assume not, both patches from 4.0.0 are already applied to 4.1.0 source.

@ViliusSutkus89 ViliusSutkus89 requested a review from andiwand July 30, 2024 21:42
@andiwand andiwand merged commit 6b93ca7 into main Jul 31, 2024
55 checks passed
@andiwand andiwand deleted the odrcore/4.1.0 branch July 31, 2024 07:06
@andiwand
Copy link
Member

I wonder if we should use this repo now to trigger version bumps for the core. Currently the core CI will push to the conan repo which broke because I has to reset the artifactory. Or we just use both? So we can also profit from the build cache. What do you think @ViliusSutkus89 @TomTasche ?

@TomTasche
Copy link
Member

Currently the core CI will push to the conan repo which broke because I has to reset the artifactory

Wait, you have to reset artifactory every time the core CI pushes to the conan repository? Why?

@andiwand
Copy link
Member

sorry poor phrasing. I had to reset the artifactory because it broke somehow.

the core CI pushes releases to the artifactory which was then lost after the reset

@ViliusSutkus89
Copy link
Contributor Author

Having odr.core here benefits us with dependency chain management and rebuilds. Here we also have the Android toolchain with the particular arch/api level matrix. I don't mind that there's two places, which publish artifacts, I just don't know what do we gain in this scenario

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants