config data paths #392
Merged
config data paths #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds data paths from poppler, fontconfig and pdf2htmlex to
HtmlConfig. This seems a bit odd but I believe it is ultimately the best choice. We decided to use a single config struct to steer all html translations. This makes the interface way easier and more generic. Since data paths are generally only known at runtime (Android/iOS) we have to communicate them somehow. Previously this was done via environment variables but I think it is more generic to use C++ and to put it directly into theHtmlConfigas it ultimately configures the HTML translation.The paths known at compile time are defaulted into these new config params. Note that these default paths will not be meaningful for some platforms and we might even want to hide them from the binary.