feature: add image support for Format and Table #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- @opendatasoft/[email protected] - @opendatasoft/[email protected]
This reverts commit c1fd872.
- @opendatasoft/[email protected] - @opendatasoft/[email protected]
|
Coverage after merging feature/sc-46281/table-sdk-display-images into chore/add-accessors will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Coverage after merging feature/sc-46281/table-sdk-display-images into chore/add-accessors will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
etienneburdet
force-pushed
the
feature/sc-46281/table-sdk-display-images
branch
from
2d38abd to
1d6f908
Compare
|
Coverage after merging feature/sc-46281/table-sdk-display-images into chore/add-accessors will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
etienneburdet
force-pushed
the
chore/add-accessors
branch
2 times, most recently
from
76b16fe to
c3334ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The goal for this PR is to add image support for the table and the Format.
(Internal for Opendatasoft only) Associated Shortcut ticket: sc-.
Changes
I added a new format component
ImageFormat, which is basically a mix of URL for the display and geo for the tooltip. The current maxWidth is a bit arbitrary, not sure customizable we want that.I also added the
FileRecordtype to api-client, athough we don't have much typing on records yet. It's just useful at this point, so why not sharing it?Review checklist