Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX][API-CLIENT] Update dataset exports formats #260

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

KevinFabre-ods
Copy link
Contributor

Summary

The goal for this PR is to add new dataset export formats

  • geographic formats: fgb, gpx and parquet
  • calendar format: ical

(Internal for Opendatasoft only) Associated Shortcut ticket: sc-51661.

- Add geographic formats: fgb, gpx and parquet
- Add calendar format: ical
Copy link

Coverage after merging chore/update-dataset-export-formats into main will be

94.67%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   index.ts100%100%100%100%
src/client
   constants.ts100%100%100%100%
   error.ts100%100%100%100%
   index.ts84.14%74.03%100%95.31%102–103, 124, 13, 146, 148, 148–149, 15, 15, 151, 162, 169, 169, 17, 17, 171, 176, 179, 182, 184, 52, 82
   types.ts100%100%100%100%
src/odsql
   clauses.ts82.61%71.43%80%90.91%14, 32, 42
   index.ts92.05%83.72%95.74%94.19%111, 146, 25, 28, 56–57, 57, 57–58, 68, 78–79

Copy link
Contributor

@richterb richterb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why the older one such as GPX and iCal were left out, they're used in ODS UIs so they're not secret on purpose. Probably just an oversight

@KevinFabre-ods KevinFabre-ods merged commit 91704ce into main Sep 20, 2024
1 check passed
@KevinFabre-ods KevinFabre-ods deleted the chore/update-dataset-export-formats branch September 20, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants