Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT][TABLE] Add option to unstyle table component #224

Conversation

KevinFabre-ods
Copy link
Contributor

@KevinFabre-ods KevinFabre-ods commented Feb 13, 2024

⚠️ This PR introduces SASS support in the style tag. To have scss highlighted in VSCODE follow instruction in this article https://daveceddia.com/svelte-with-sass-in-vscode/

Summary

The goal for this PR is to add an unstyled props to reset all presentation style.

Screenshot 2024-02-13 at 11 57 56

(Internal for Opendatasoft only) Associated Shortcut ticket: sc-46255.

Changes

To be tested

  • Snapshots shouldn't changes.

Review checklist

  • Description is complete
  • Commits respect the Conventional Commits Specification
  • 2 reviewers (1 if trivial)
  • Tests coverage has improved
  • Code is ready for a release on NPM

@KevinFabre-ods KevinFabre-ods force-pushed the feature/sc-47932/sdk-set-the-table-default-style branch from d30d146 to 5338953 Compare February 13, 2024 13:12
@KevinFabre-ods KevinFabre-ods marked this pull request as ready for review February 13, 2024 13:18
@KevinFabre-ods KevinFabre-ods added the enhancement New feature or request label Feb 13, 2024
Default is false; Is set to true: Remove any presentation style that is applied to the table
@KevinFabre-ods KevinFabre-ods force-pushed the feature/sc-47932/sdk-set-the-table-default-style branch from 5338953 to 029dd12 Compare February 21, 2024 16:12
Use a lot the :global style element to not scope style. HTML don't have a scoped classname, so it's easier to override the default style.
@KevinFabre-ods
Copy link
Contributor Author

KevinFabre-ods commented Feb 22, 2024

@etienneburdet I updated a bit the styling here 4d9ce81

I removed the CSS variables.
Now Table components has scoped classnames on their HTML elements, this leads to a simple style override.

Copy link
Contributor

@etienneburdet etienneburdet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended, ok for me to ship that. As with the formatting one, global and scss nesting doesn't really play together, but well… there is no great solution to that.

@KevinFabre-ods KevinFabre-ods merged commit f7db9b8 into feature/sc-46247/sdk-new-visualization-table Feb 23, 2024
5 of 7 checks passed
@KevinFabre-ods KevinFabre-ods deleted the feature/sc-47932/sdk-set-the-table-default-style branch February 23, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants