Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT][POI Maps] Fullscreen control #217

Merged

Conversation

KevinFabre-ods
Copy link
Contributor

@KevinFabre-ods KevinFabre-ods commented Jan 15, 2024

Summary

The goal for this PR is to add fullscreen controls to the POI maps

(Internal for Opendatasoft only) Associated Shortcut ticket: sc-45176.

Screen.Recording.2024-01-15.at.17.25.29.mov

Changes

Factorize functions to add / remove controls
Controls still react to the map interactivity and the active popup (if type is modal)

Open discussions

I didn't took the time to fit to the UI described in Zeplin where controls are in the same group.
I took the short path where most of this feature is handled natively by Maplibre.

Screenshot 2024-01-15 at 17 35 41

To follow this Zeplin UI we need to globally override how controls are created which can be time consuming. @BenoitFortune I can create a Story to keep track a potential evolution.

Review checklist

  • Description is complete
  • Commits respect the Conventional Commits Specification
  • 2 reviewers (1 if trivial)
  • Tests coverage has improved
  • Code is ready for a release on NPM

@KevinFabre-ods KevinFabre-ods marked this pull request as ready for review January 15, 2024 16:41
Copy link
Contributor

@cybervinvin cybervinvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼
Very light code for a very good feature 🤩 GG
I tested on a studio page (not in storybook) and it works as expected.
🚀

@KevinFabre-ods KevinFabre-ods merged commit d046d1a into main Jan 23, 2024
11 checks passed
@KevinFabre-ods KevinFabre-ods deleted the feature/sc-45176/sdk-allow-maps-to-be-in-full-screen branch January 23, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants