Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/chromatic pr #215

Closed
wants to merge 28 commits into from
Closed

Test/chromatic pr #215

wants to merge 28 commits into from

Conversation

wmai
Copy link
Contributor

@wmai wmai commented Jan 11, 2024

Summary

The goal for this PR is to ...

(Internal for Opendatasoft only) Associated Shortcut ticket: sc-.

Changes

describe the code changes introduced in this PR and the logic behind those changes

Breaking Changes

describe the changes that are not backward compatible

Changelog

short sentence to serve as a public changelog:

For a bug: "We fixed a bug in the Map component: Middle-Earth's vector tiles are now available."

For a new feature: "In the Map component: It's now possible to display the route of Frodo's journey from Hobbiton to Mount Doom."

Open discussion

describe implementation points that you would like to discuss if any

describe functional behaviour that you would like to discuss if any

To be tested

points that may not be obviously related to the changes but are impacted

special cases that are not widely known

Review checklist

  • Description is complete
  • Commits respect the Conventional Commits Specification
  • 2 reviewers (1 if trivial)
  • Tests coverage has improved
  • Code is ready for a release on NPM

@wmai wmai marked this pull request as ready for review January 11, 2024 08:11
@wmai wmai closed this Jan 11, 2024
@wmai wmai reopened this Jan 11, 2024
@wmai wmai marked this pull request as draft January 11, 2024 08:17
@wmai wmai marked this pull request as ready for review January 11, 2024 08:22
@wmai wmai closed this Jan 11, 2024
@wmai wmai deleted the test/chromatic-pr branch January 11, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants