[SC-44672][FEAT] Add new legend symbol: Image
#204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etienneburdet
approved these changes
Nov 24, 2023
...ges/visualizations/src/components/Legend/CategoryLegend/Item/CategoryLegendItemSymbol.svelte
Show resolved
Hide resolved
RafaelSzmarowski
approved these changes
Nov 24, 2023
There was a problem hiding this comment.
LGTM ! Nice and smooth, I don't know about the alt property, my first thought was that we can always add one but then, the legend has a label so it seems a little bit duplicating the information ! We have no alt on the KPIs image so I guess shouldn't be a problem here too
KevinFabre-ods
force-pushed
the
feature/sc-44672/studio-exploration-tech-create-png-images
branch
2 times, most recently
from
affcb28 to
edf3e31
Compare
KevinFabre-ods
force-pushed
the
feature/sc-44672/add-new-legend-symbol--image
branch
from
cba597f to
4bf7bfd
Compare
Base automatically changed from
feature/sc-44672/studio-exploration-tech-create-png-images
to
main
November 24, 2023 15:21
KevinFabre-ods
deleted the
feature/sc-44672/add-new-legend-symbol--image
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The goal for this PR is to add a new legend symbol in the legend.
Render an image as a legend item by providing an URL
(Internal for Opendatasoft only) Associated Shortcut ticket: sc-44672.
Changes
Breaking Changes
describe the changes that are not backward compatible
Open discussion
Should we add the alt property ?
To be tested
Try to load large images to break the legend layout
Review checklist