fix: destructure style options #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etienneburdet
force-pushed
the
chore/stabilize-style-options
branch
from
62f26dd to
b22eab8
Compare
KevinFabre-ods
approved these changes
Nov 9, 2023
There was a problem hiding this comment.
LGTM ! 👏
Do you need help to release the NPM packages ?
Normally, it should be fine if you follow these instructions
Let's merge release then! 👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The goal for this PR is to destructure the style options, so that the reactive call is not triggered if
optionsbut notoptions.stylechanges.Admittedly,
{#key …and$: …seems to work differently on that matter.Review checklist