Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX][POI Map] Improve cursor #191

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

KevinFabre-ods
Copy link
Contributor

Summary

The goal for this PR is to fix the cursor style when using a POI map

  • no interaction: default
  • drag: move
  • hover a feature with a popup: pointer
Screen.Recording.2023-09-22.at.16.43.22.mov

(Internal for Opendatasoft only) Associated Shortcut ticket: sc-43610.

Review checklist

  • Description is complete
  • Commits respect the Conventional Commits Specification
  • 2 reviewers (1 if trivial)
  • Tests coverage has improved
  • Code is ready for a release on NPM

no interaction: default
drag: move
hover a feature with a popup: pointer
@KevinFabre-ods KevinFabre-ods force-pushed the feature/sc-43610/sdk-poi-map-improve-cursor branch from 6b28ba8 to ccf8dfc Compare September 22, 2023 14:48
Copy link
Contributor

@RafaelSzmarowski RafaelSzmarowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@KevinFabre-ods KevinFabre-ods merged commit 7386dd7 into main Sep 27, 2023
4 checks passed
@KevinFabre-ods KevinFabre-ods deleted the feature/sc-43610/sdk-poi-map-improve-cursor branch September 27, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants