[FEAT][PoiMap][SC-43161] Show popup on feature click

[KevinFabre-ods]

Summary

The goal for this PR is to show popup on the map after a feature has been clicked.

(Internal for Opendatasoft only) Associated Shortcut ticket: sc-43161.

Changes

Poi map can now display popup when a feature is clicked.

To do so, a popup config object must be defined in a layer.

{
 ...layerConfig, 
 popup: {
    display: 'sidebar', // or 'tooltip'
    getContent: (id: GeoJSONFeature['id'], properties?: GeoJsonProperties) => 'my popup content'; 
   }
}

The SDK provides only a skeleton (positioning and content container style) for the popup.
Popup content comes from the result of getContent.

Also when interaction is switch off:

• The view box is reset to the bbox
• The popup is closed

Breaking Changes

none

To be tested

• Try to use multiples sources (from different types) and layers
• Try to used asynchronous calls to define the popup content
• All props changes should be taken into consideration by the map

Review checklist

• Description is complete
• Commits respect the Conventional Commits Specification
• 2 reviewers (1 if trivial)
• Tests coverage has improved
• Code is ready for a release on NPM

[KevinFabre-ods]

@RafaelSzmarowski and @wmai Sorry, I didn't realize my latest rebase broke the commit history.

Now this PR also only changes related to the popup 😉

[etienneburdet]

Looks really clean! The map and maprender implem look really nicer, easier to read and more stable.

There are just two little things I'd rather do without: the queue mechanism and the .bind(this). This are pattern I'm not sure everybody in the future will know. Moving to a Svelte component should solve that, while leveraging 99% of this code (this is for another PR).

The popup I feel like could be done as a mix of maplibre'spopup or HTML (especially if we want to support more "sidebar" stuff, like next to the map).

Anyways, these comments are a bit more far fetch and doesn't block merge imo. I'll approve if you want to leave it like this.

[KevinFabre-ods]

There are just two little things I'd rather do without: the queue mechanism and the .bind(this). This are pattern I'm not sure everybody in the future will know. Moving to a Svelte component should solve that, while leveraging 99% of this code (this is for another PR).

👍
Let's make a ticket where we save all technical / refactor ideas we have for the Map components

➡️ https://app.shortcut.com/opendatasoft/story/43544

[RafaelSzmarowski]

LGTM ! Nice work

[KevinFabre-ods]

Before merge I'll do a squash to keep only two commits:

• a feat commit feat(PoiMap): can display a popup on feature click
• and the chore: publish new versions (that will be drop when [FEATURE] POI Map #164) is merged in main