fix: fix radar chart grid color

opendatasoft · Mar 19, 2024 · 9122e5f · 9122e5f
1 parent 1c616ff
commit 9122e5f
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 8 deletions.
diff --git a/packages/visualizations/src/components/Chart/scales.ts b/packages/visualizations/src/components/Chart/scales.ts
@@ -47,11 +47,7 @@ const computeGridLineColor: (
 ) => GridLineOptions['color'] = (display) => (context) => {
     if (!context?.scale?.ticks) return 'rgba(0, 0, 0, 0)';
     const ticksAbsoluteValues = context.scale.ticks.map((tick) => Math.abs(tick.value));
-    let minAbsoluteTicksIndex = ticksAbsoluteValues.indexOf(Math.min(...ticksAbsoluteValues));
-    if (context.scale.type === 'radialLinear') {
-        // On radar, chartjs compute one supplementary grid line
-        minAbsoluteTicksIndex -= 1;
-    }
+    const minAbsoluteTicksIndex = ticksAbsoluteValues.indexOf(Math.min(...ticksAbsoluteValues));
     if (display) {
         if (context.index === minAbsoluteTicksIndex) return 'rgba(0, 0, 0, 0.4)';
         if (display !== 'single') return 'rgba(0, 0, 0, 0.1)';

diff --git a/packages/visualizations/src/components/Map/WebGl/ChoroplethVectorTiles.svelte b/packages/visualizations/src/components/Map/WebGl/ChoroplethVectorTiles.svelte
@@ -41,7 +41,6 @@
     let colorScale: ColorScale;
 
     let aspectRatio: number | undefined;
-    let maxZoom: number;
     let renderTooltip: MapRenderTooltipFunction;
     let bbox: BBox | undefined;
     let activeShapes: string[] | undefined;
@@ -73,7 +72,6 @@
         colorScale = DEFAULT_COLORSCALE,
         legend,
         aspectRatio,
-        maxZoom = 4,
         activeShapes,
         interactive = defaultInteractive,
         emptyValueColor = DEFAULT_COLORS.Default,
@@ -148,7 +146,6 @@
     {source}
     {layer}
     {aspectRatio}
-    {maxZoom}
     {dataBounds}
     {colorScale}
     {legend}