Skip to content

Commit

Permalink
feat: upgrade to node 20 (#228)
Browse files Browse the repository at this point in the history
  • Loading branch information
etienneburdet authored Apr 12, 2024
1 parent 8b571c9 commit 2e9803e
Show file tree
Hide file tree
Showing 29 changed files with 64,243 additions and 46,352 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/api-client.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
node: ['16.17.1']
node: ["18.x", "20.x"]
os: [ubuntu-latest]

steps:
Expand Down
27 changes: 9 additions & 18 deletions .github/workflows/visualizations.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
node: ["16.17.1"]
node: ["18.x", "20.x"]
os: [ubuntu-latest]

steps:
Expand All @@ -31,12 +31,9 @@ jobs:
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node }}

- name: Install
run: npm ci

- name: Bootstrap
run: npm run bootstrap
- name: Build
run: npm run build-ci

- name: Test
run: npm test
Expand All @@ -47,7 +44,7 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
node: ["16.17.1"]
node: ["18.x", "20.x"]
os: [ubuntu-latest]

steps:
Expand All @@ -59,11 +56,8 @@ jobs:
with:
node-version: ${{ matrix.node }}

- name: Install
run: npm ci

- name: Bootstrap
run: npm run bootstrap
- name: Build
run: npm run build-ci

- name: Lint
run: npm run lint
Expand All @@ -73,7 +67,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node: [">=16 <18"]
node: ["18.x", "20.x"]

needs: [test, lint]

Expand All @@ -88,11 +82,8 @@ jobs:
with:
node-version: ${{ matrix.node }}

- name: Install
run: npm ci

- name: Bootstrap
run: npm run bootstrap
- name: Build
run: npm run build-ci

- name: Build storybook
run: npm run build-storybook
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v16.17.1
v20.11.1
8 changes: 1 addition & 7 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,7 @@ This is a monorepo managed with npm and [lerna](https://github.com/lerna/lerna).
npm install
```

Then bootstrap all the packages:

```shell
npm run bootstrap
```

Or if you want to watch and rebuild all packages:
If you want to watch and rebuild all packages:

```shell
npm run watch
Expand Down
4 changes: 4 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ A monorepo for the Opendatasoft's libraries:
- [`@opendatasoft/visualizations`](packages/visualizations/): Components to easily build dashboards and visualizations on top of an Opendatasoft platform.
- [`@opendatasoft/visualizations-react`](packages/visualizations-react/): A convenient React wrapper for the visualizations components.

## Running packages locally
Install the monorepo with: `npm install` (`lerna boostrap` is now deprecated).
Run the all the packages with: `npm run watch`. Changes will propagate from one repo to the other.

## Contributing

This project welcomes contributions and suggestions! To do so, take a look at our [Contributing Guide](CONTRIBUTING.md). It contains setup instructions, tools and scripts that can be useful if you need to work on all packages at the same time.
Expand Down
3 changes: 0 additions & 3 deletions lerna.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,4 @@
{
"packages": [
"packages/*"
],
"version": "independent",
"command": {
"version": {
Expand Down
Loading

2 comments on commit 2e9803e

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverage for this commit

94.64%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
src
   index.ts100%100%100%
src/client
   error.ts100%100%100%
   index.ts74.03%100%95.31%102–103, 124, 13, 146, 148, 148–149, 15, 15, 151, 162, 169, 169, 17, 17, 171, 176, 179, 182, 184, 52, 82
   types.ts100%100%100%
src/odsql
   clauses.ts71.43%80%90.91%14, 32, 42
   index.ts83.72%95.74%94.19%111, 146, 25, 28, 56–57, 57, 57–58, 68, 78–79

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverage for this commit

94.64%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
src
   index.ts100%100%100%
src/client
   error.ts100%100%100%
   index.ts74.03%100%95.31%102–103, 124, 13, 146, 148, 148–149, 15, 15, 151, 162, 169, 169, 17, 17, 171, 176, 179, 182, 184, 52, 82
   types.ts100%100%100%
src/odsql
   clauses.ts71.43%80%90.91%14, 32, 42
   index.ts83.72%95.74%94.19%111, 146, 25, 28, 56–57, 57, 57–58, 68, 78–79

Please sign in to comment.