vllm.config: add _set_missing_architectures #119
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtrifiro
force-pushed
the
fix-serving-for-granite-starter
branch
from
bdcb612 to
8654ff7
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtrifiro The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
dtrifiro
changed the title
|
Closing as the the architecture field was added in the model's |
prarit
pushed a commit
to prarit/vllm
that referenced
this pull request
Oct 18, 2024
* add weight padding for moe * enable padding by default * fix linter * fix linter * fix linter * using envs.py * fix linter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some models, such as
granite-7b-starter, do not include thearchitectureslist in theirconfig.json, causing a crash when trying to serve the model with vLLM.This patch attempts to automatically guess the correct architecture when the field is not provided.
https://issues.redhat.com/browse/RHOAIENG-10722