[Frontend] add build_server and make run_server async #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Travis Johnson <[email protected]>
…ed. (vllm-project#6645) Signed-off-by: Thomas Parnell <[email protected]>
Co-authored-by: Michael Goin <[email protected]>
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtrifiro The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
dtrifiro
force-pushed
the
entrypoint-split-server
branch
3 times, most recently
from
f2d9ecb to
08f4f19
Compare
Xaenalt
pushed a commit
that referenced
this pull request
Sep 18, 2024
prarit
pushed a commit
to prarit/vllm
that referenced
this pull request
Oct 18, 2024
Update Dockerfile.rocm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aims to split
run_serverinto two: one part responsible for building theuvicorn.Serverand another responsible for running it.With this:
run_server()is now a coroutine, which can be run usingasyncio.run()or just awaited when running in an async contextbuild_server()can now take optional kwargs, which are passed to uvicorn and allow for further customization of the server