Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix github.com/elazarl/goproxy Denial of Service #24

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

spolti
Copy link
Member

@spolti spolti commented Nov 21, 2023

Description

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@spolti
Copy link
Member Author

spolti commented Nov 21, 2023

CI issue will be fixed by #25

@israel-hdez
Copy link

@spolti Can you rebase, to check that it would build now?

Copy link

@israel-hdez israel-hdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still would prefer to reserve main for code syncs.
I'm, anyway, approving.

Copy link

openshift-ci bot commented Nov 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: israel-hdez, spolti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 09e54c6 into opendatahub-io:main Nov 22, 2023
7 checks passed
@spolti spolti deleted the goproxy branch November 23, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants