Add kserve private endpoint tests #22

lugi0 · 2024-10-23T13:38:24Z

Description

Adding two tests for kserve private endpoints.

How Has This Been Tested?

This has been tested multiple times from a local environment. It passes most of the time, but rarely fails on one of the assert calls in test_curl_with_istio because it receives an empty reply rather than an OK - might be a timing related problem, but seems weird because it is usually the second assert that fails.

If you want to run the tests yourself you will need to run uv run pytest tests/model_serving/model_server/private_endpoint/

Merge criteria:

[x ] The commits are squashed in a cohesive manner and have meaningful messages.
[x ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x ] The developer has manually tested the changes and verified that the changes work

Signed-off-by: lugi0 <[email protected]>

for more information, see https://pre-commit.ci

Signed-off-by: lugi0 <[email protected]>

for more information, see https://pre-commit.ci

…tion, specify in README that pre-commit shoulb be run and needs NPM installed Signed-off-by: lugi0 <[email protected]>

Signed-off-by: lugi0 <[email protected]>

tests/model_serving/model_server/private_endpoint/constants.py

tests/model_serving/model_server/private_endpoint/test_kserve_private_endpoint.py

uv.lock

README.md

mypy.ini

tests/model_serving/model_server/private_endpoint/conftest.py

tests/model_serving/model_server/private_endpoint/utils.py

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* [pre-commit.ci] pre-commit autoupdate updates: - [github.com/astral-sh/ruff-pre-commit: v0.7.0 → v0.7.1](astral-sh/ruff-pre-commit@v0.7.0...v0.7.1) - [github.com/renovatebot/pre-commit-hooks: 38.129.0 → 38.133.1](renovatebot/pre-commit-hooks@38.129.0...38.133.1) - [github.com/gitleaks/gitleaks: v8.21.1 → v8.21.2](gitleaks/gitleaks@v8.21.1...v8.21.2) - [github.com/pre-commit/mirrors-mypy: v1.12.1 → v1.13.0](pre-commit/mirrors-mypy@v1.12.1...v1.13.0) * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

updates: - [github.com/astral-sh/ruff-pre-commit: v0.7.1 → v0.7.2](astral-sh/ruff-pre-commit@v0.7.1...v0.7.2) - [github.com/renovatebot/pre-commit-hooks: 38.133.1 → 39.0.0](renovatebot/pre-commit-hooks@38.133.1...39.0.0) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Signed-off-by: lugi0 <[email protected]>

…tion, specify in README that pre-commit shoulb be run and needs NPM installed Signed-off-by: lugi0 <[email protected]>

…TING.MD Signed-off-by: lugi0 <[email protected]>

Signed-off-by: lugi0 <[email protected]>

tests/model_serving/model_server/private_endpoint/conftest.py

tests/model_serving/model_server/private_endpoint/utils.py

Signed-off-by: lugi0 <[email protected]>

tests/conftest.py

tests/model_serving/model_server/private_endpoint/test_kserve_private_endpoint.py

tests/model_serving/model_server/private_endpoint/utils.py

Signed-off-by: lugi0 <[email protected]>

tests/conftest.py

tests/model_serving/model_server/private_endpoint/conftest.py

tests/constants.py

Signed-off-by: lugi0 <[email protected]>

Add kserve private endpoint tests

a0bccd6

Signed-off-by: lugi0 <[email protected]>

lugi0 requested review from mwaykole, rnetser and tarukumar October 23, 2024 13:38

lugi0 self-assigned this Oct 23, 2024

lugi0 and others added 6 commits October 23, 2024 15:38

Merge branch 'main' into feature/kserve_private_endpoint

f920126

[pre-commit.ci] auto fixes from pre-commit.com hooks

078605a

for more information, see https://pre-commit.ci

Fix typing annotations

b44312f

Signed-off-by: lugi0 <[email protected]>

[pre-commit.ci] auto fixes from pre-commit.com hooks

9fbaf1f

for more information, see https://pre-commit.ci

Fix pre-commit checks, add mypy ini file for vscode extension integra…

df6c2e0

…tion, specify in README that pre-commit shoulb be run and needs NPM installed Signed-off-by: lugi0 <[email protected]>

Fix typo in function signature

863127c

Signed-off-by: lugi0 <[email protected]>

lugi0 added the kind/enhancement New feature or request label Oct 23, 2024

lugi0 commented Oct 23, 2024

View reviewed changes

tests/model_serving/model_server/private_endpoint/constants.py Outdated Show resolved Hide resolved