Refactor DownloadManifests in deploy for clarity and modularity #1436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added helper functions for directory creation and tar file processing. - Enhanced readability by isolating core operations into smaller, focused functions. - Simplified error handling and ensured consistent error messages. Update pkg/deploy/deploy.go Co-authored-by: Gerard Ryan <[email protected]> renamed processTarHeader to extractFileOrDirectory
|
/retest |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1436 +/- ##
=======================================
Coverage ? 25.57%
=======================================
Files ? 67
Lines ? 5526
Branches ? 0
=======================================
Hits ? 1413
Misses ? 3940
Partials ? 173 ☔ View full report in Codecov by Sentry. |
grdryn
approved these changes
Dec 12, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grdryn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 47007f2
into
opendatahub-io:main
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the DownloadManifests function in the deploy package to improve its structure, readability, and maintainability.
The PR introduces the following key changes:
errPathResolutionFailed, anderrPathIrrelevant.unpackTarFromReader.resolveTargetPath.processTarHeaderandwriteFileFromTarfor better organization.createDirectoryfunction.defercheckers.How Has This Been Tested?
Screenshot or short clip
Merge criteria